Feature/admob 2021 Set|Get RequestConfiguration #665
Conversation
* removed some BannerViewHelper code, the rest requires upcoming listener revamp * added <string.h> include to banner_view_internal_android.cc
* removed nativeAdExpress and rewardedVideo iOS impls * removed extra comma in admob testapp project
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // Convert a NSArray into a vector of strings. Asserts if a non NSString | ||
| // object is found in the array. | ||
| void NSArrayToStdStringVector(NSArray* array, | ||
| std::vector<std::string>* string_vector); |
There was a problem hiding this comment.
This file is confusing the linter. #include is indeed at the top of this file.
admob/src/include/firebase/admob.h
Outdated
| /// @note: on iOS, the | ||
| /// @ref RequestConfiguration::tag_for_child_directed_treatment and | ||
| /// @ref RequestConfiguration::tag_for_under_age_of_consent fields will be set | ||
| /// set to kChildDirectedTreatmentUnspecified, and |
There was a problem hiding this comment.
nit: "set" is written twice.
There was a problem hiding this comment.
Thanks, will fix.
app/src/util_ios.h
Outdated
| @@ -192,6 +193,11 @@ void ForEachAppDelegateClass(void (^block)(Class)); | |||
| NSMutableArray *StringVectorToNSMutableArray( | |||
| const std::vector<std::string> &vector); | |||
|
|
|||
| // Convert a NSArray into a vector of strings. Asserts if a non NSString | |||
| // object is found in the array. | |||
| void NSArrayToStdStringVector(NSArray* array, | |||
There was a problem hiding this comment.
soft suggested name: NSArrayOfNSStringToVectorOfString
| @@ -24,16 +24,6 @@ | |||
| GADRequest *GADRequestFromCppAdRequest(AdRequest adRequest) { | |||
| // Create the GADRequest. | |||
| GADRequest *request = [GADRequest request]; | |||
|
|
|||
| // Test devices. | |||
| if (adRequest.test_device_id_count > 0) { | |||
There was a problem hiding this comment.
Are these set elsewhere now?
There was a problem hiding this comment.
Yes, they were once per ad request, now they're part of RequestConfiguration structure. set globally through SetRequestConfigration(). No need to set them each and every time anymore!
| // Convert a NSArray into a vector of strings. Asserts if a non NSString | ||
| // object is found in the array. | ||
| void NSArrayOfNSStringToVectorOfString(NSArray* array, | ||
| std::vector<std::string>* string_vector); |
There was a problem hiding this comment.
Add #include <vector> for vector<>
There was a problem hiding this comment.
This file is confusing the linter. #include is indeed at the top of this file.
github-actions
bot
added
the
tests: in-progress
❌ Integration test FAILEDRequested by @DellaBitta on commit 80f50ff
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Added functions which allow customers to configure the types of Ads that Admob returns. Whereas this configuration used to be done per AdRequest, this new implementation moves the configuration into the global scope.