Functions to Disable AdMob Automatic Services on iOS #772
Conversation
| void NSArrayOfNSStringToVectorOfString(NSArray* array, | ||
| std::vector<std::string>* string_vector); | ||
| void NSArrayOfNSStringToVectorOfString(NSArray *array, | ||
| std::vector<std::string> *string_vector); |
There was a problem hiding this comment.
#include <vector> is indeed at the top of this file.
... fixed.
| } | ||
|
|
||
| TEST_F(FirebaseAdMobTest, TestDisableMediationInitialization) { | ||
| firebase::admob::DisableMediationInitialization(); |
There was a problem hiding this comment.
It seems like these tests aren't really testing the functionality, since it needs to be called before initialization. I think a comment regarding what this is actually testing (that calling the function won't have issues, and not necessarily the functionality) would be good.
There was a problem hiding this comment.
You could also implement a second test fixture class that doesn't automatically initialize AdMob to test what happens when you call these before initialization.
| } | ||
|
|
||
| TEST_F(FirebaseAdMobTest, TestDisableMediationInitialization) { | ||
| firebase::admob::DisableMediationInitialization(); |
There was a problem hiding this comment.
You could also implement a second test fixture class that doesn't automatically initialize AdMob to test what happens when you call these before initialization.
github-actions
bot
added
the
tests: in-progress
❌ Integration test FAILEDRequested by @DellaBitta on commit f655518
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Description
Add iOS-specific functions to disable some automatic services:
DisableSDKCrashReporting()DisableMediationInitialization()These functions have no behavior on Android.
Fulfills b/206022469
Testing
Integration Test CI #1
And again after merging feature branch to this one.
And again after adding pre-init testing.
Type of Change
Place an
xthe applicable box: