-
Notifications
You must be signed in to change notification settings - Fork 124
Functions to Disable AdMob Automatic Services on iOS #772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
b16c5bd
06fd652
d5a20bb
f758f61
086b7b1
7db673d
4804fce
677e0e4
c8b3160
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -195,8 +195,8 @@ NSMutableArray *StringVectorToNSMutableArray( | |
|
||
// Convert a NSArray into a vector of strings. Asserts if a non NSString | ||
// object is found in the array. | ||
void NSArrayOfNSStringToVectorOfString(NSArray* array, | ||
std::vector<std::string>* string_vector); | ||
void NSArrayOfNSStringToVectorOfString(NSArray *array, | ||
std::vector<std::string> *string_vector); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
... fixed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably the linter either doesn't know that OBJC will be defined, you could move the c++-specific includes outside of that ifdef. Or just ignore. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed. |
||
|
||
// Convert a string map to NSDictionary. | ||
NSDictionary *StringMapToNSDictionary( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like these tests aren't really testing the functionality, since it needs to be called before initialization. I think a comment regarding what this is actually testing (that calling the function won't have issues, and not necessarily the functionality) would be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also implement a second test fixture class that doesn't automatically initialize AdMob to test what happens when you call these before initialization.