Skip to content

Use the v9 quickstart branch until the v9 release #9648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 14, 2022
Merged

Use the v9 quickstart branch until the v9 release #9648

merged 5 commits into from
Apr 14, 2022

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Apr 13, 2022 •
edited
Loading

#no-changelog

@paulb777 paulb777 added this to the Firebase 9 milestone Apr 13, 2022
@google-oss-bot
Copy link

Size Report 1

Affected Products

  • FirebaseFunctions

    TypeBase (1793deb)Merge (9502a3b)Diff
    CocoaPods?928 kB? (?)

  • FirebaseStorage

    TypeBase (1793deb)Merge (9502a3b)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/FU9X0Wt2Zb.html

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseStorage-iOS-FirebaseStorage.framework

    Overall coverage changed from ? (1793deb) to 0.00% (9502a3b) by ?.

    13 individual files with coverage change

    FilenameBase (1793deb)Merge (9502a3b)Diff
    AsyncAwait.swift?0.00%?
    Result.swift?0.00%?
    Storage.swift?0.00%?
    StorageComponent.swift?0.00%?
    StorageDownloadTask.swift?0.00%?
    StorageError.swift?0.00%?
    StorageListResult.swift?0.00%?
    StorageMetadata.swift?0.00%?
    StorageObservableTask.swift?0.00%?
    StorageReference.swift?0.00%?
    StorageTask.swift?0.00%?
    StorageTaskSnapshot.swift?0.00%?
    StorageUploadTask.swift?0.00%?

  • FirebaseStorage-iOS-FirebaseStorageInternal.framework

    Overall coverage changed from ? (1793deb) to 0.00% (9502a3b) by ?.

    18 individual files with coverage change

    FilenameBase (1793deb)Merge (9502a3b)Diff
    FIRStorage.m?0.00%?
    FIRStorageDeleteTask.m?0.00%?
    FIRStorageDownloadTask.m?0.00%?
    FIRStorageErrors.m?0.00%?
    FIRStorageGetDownloadURLTask.m?0.00%?
    FIRStorageGetMetadataTask.m?0.00%?
    FIRStorageListResult.m?0.00%?
    FIRStorageListTask.m?0.00%?
    FIRStorageMetadata.m?0.00%?
    FIRStorageObservableTask.m?0.00%?
    FIRStoragePath.m?0.00%?
    FIRStorageReference.m?0.00%?
    FIRStorageTask.m?0.00%?
    FIRStorageTaskSnapshot.m?0.00%?
    FIRStorageTokenAuthorizer.m?0.00%?
    FIRStorageUpdateMetadataTask.m?0.00%?
    FIRStorageUploadTask.m?0.00%?
    FIRStorageUtils.m?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/tRQ0fGXZBH.html

@paulb777
Copy link
Member Author

The storage failure is a regression or exposure from #9576 that wasn't caught because that PR was from a fork.

@paulb777 paulb777 requested a review from ncooke3 April 14, 2022 13:22
@paulb777 paulb777 merged commit 49b411d into master Apr 14, 2022
@paulb777 paulb777 deleted the pb-qs-v9 branch April 14, 2022 15:16
@firebase firebase locked and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
api: storage
Projects
None yet
Milestone
Firebase 9
Development

Successfully merging this pull request may close these issues.

Fix prerelease tests for v9
3 participants
@paulb777 @google-oss-bot @ncooke3