Skip to content

Use the v9 quickstart branch until the v9 release #9648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 14, 2022
Merged

Use the v9 quickstart branch until the v9 release #9648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
347a809
Use the v9 quickstart branch until the v9 release
paulb777 Apr 13, 2022
379c0e4
Turn Functions and Storage QS CI back on
paulb777 Apr 13, 2022
5125b26
Print key on failure
paulb777 Apr 13, 2022
c9032fc
debug
paulb777 Apr 14, 2022
04ba5c4
restore
paulb777 Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 23 additions & 24 deletions .github/workflows/functions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,31 +82,30 @@ jobs:
- name: Unit Tests
run: scripts/third_party/travis/retry.sh ./scripts/build.sh FirebaseFunctionsUnit ${{ matrix.target }} spm

# TODO: Restore Quickstart when ported for Firebase 9.
# quickstart:
# # Don't run on private repo unless it is a PR.
# if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
# env:
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
# signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
# LEGACY: true
# runs-on: macos-11
quickstart:
# Don't run on private repo unless it is a PR.
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
env:
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
LEGACY: true
runs-on: macos-11

# steps:
# - uses: actions/checkout@v2
# - name: Setup quickstart
# run: scripts/setup_quickstart.sh functions
# - name: install secret googleservice-info.plist
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-functions.plist.gpg \
# quickstart-ios/functions/GoogleService-Info.plist "$plist_secret"
# - name: Setup custom URL scheme
# run: sed -i '' 's/REVERSED_CLIENT_ID/com.googleusercontent.apps.1025801074639-6p6ebi8amuklcjrto20gvpe295smm8u6/' quickstart-ios/functions/LegacyFunctionsQuickstart/FunctionsExample/Info.plist
# - name: Test objc quickstart
# run: ([ -z $plist_secret ] ||
# scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true)
# - name: Test swift quickstart
# run: ([ -z $plist_secret ] ||
# scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true swift)
steps:
- uses: actions/checkout@v2
- name: Setup quickstart
run: scripts/setup_quickstart.sh functions
- name: install secret googleservice-info.plist
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-functions.plist.gpg \
quickstart-ios/functions/GoogleService-Info.plist "$plist_secret"
- name: Setup custom URL scheme
run: sed -i '' 's/REVERSED_CLIENT_ID/com.googleusercontent.apps.1025801074639-6p6ebi8amuklcjrto20gvpe295smm8u6/' quickstart-ios/functions/LegacyFunctionsQuickstart/FunctionsExample/Info.plist
- name: Test objc quickstart
run: ([ -z $plist_secret ] ||
scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true)
- name: Test swift quickstart
run: ([ -z $plist_secret ] ||
scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true swift)

functions-cron-only:
# Don't run on private repo.
Expand Down
39 changes: 19 additions & 20 deletions .github/workflows/storage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,26 +91,25 @@ jobs:
- name: Setup project and Build for Catalyst
run: scripts/test_catalyst.sh FirebaseStorageInternal test FirebaseStorageInternal-Unit-unit

# TODO: Restore Quickstart when ported for Firebase 9.
# quickstart:
# # Don't run on private repo unless it is a PR.
# if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
# env:
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
# signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
# LEGACY: true
# runs-on: macos-11
# steps:
# - uses: actions/checkout@v2
# - name: Setup quickstart
# run: scripts/setup_quickstart.sh storage
# - name: Install Secret GoogleService-Info.plist
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-storage.plist.gpg \
# quickstart-ios/storage/GoogleService-Info.plist "$plist_secret"
# - name: Test objc quickstart
# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Storage true)
# - name: Test swift quickstart
# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Storage true swift)
quickstart:
# Don't run on private repo unless it is a PR.
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
env:
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
LEGACY: true
runs-on: macos-11
steps:
- uses: actions/checkout@v2
- name: Setup quickstart
run: scripts/setup_quickstart.sh storage
- name: Install Secret GoogleService-Info.plist
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-storage.plist.gpg \
quickstart-ios/storage/GoogleService-Info.plist "$plist_secret"
- name: Test objc quickstart
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Storage true)
- name: Test swift quickstart
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Storage true swift)

pod-lib-lint:
# Don't run on private repo unless it is a PR.
Expand Down
4 changes: 3 additions & 1 deletion scripts/setup_quickstart.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ if check_secrets || [[ ${SAMPLE} == "installations" ]]; then
# development pod install. This is needed for the `pod install` command.
export FIREBASE_POD_REPO_FOR_DEV_POD=`pwd`

git clone https://github.com/firebase/quickstart-ios.git
#TODO: Delete the branch option after the 9.0 release.
git clone --branch v9 https://github.com/firebase/quickstart-ios.git

$scripts_dir/localize_podfile.swift "$WORKSPACE_DIR"/Podfile "$RELEASE_TESTING"
if [ "$RELEASE_TESTING" == "nightly_release_testing" ]; then
set +x
Expand Down
3 changes: 2 additions & 1 deletion scripts/setup_quickstart_framework.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ set -ex

REPO=`pwd`
if [ ! -d "quickstart-ios" ]; then
git clone https://github.com/firebase/quickstart-ios.git
#TODO: Delete the branch option after the 9.0 release.
git clone --branch v9 https://github.com/firebase/quickstart-ios.git
fi
QS_SCRIPTS="${REPO}"/quickstart-ios/scripts
cd quickstart-ios/"${SAMPLE}"
Expand Down