Missing NSObject overrides and tests #9715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
ncooke3
approved these changes
Apr 27, 2022
ncooke3
approved these changes
Apr 27, 2022
paulb777
added a commit
that referenced
this pull request
Apr 28, 2022
* Missing NSObject overrides and tests (#9715) * [v9] Improve clarity of zip integration instructions (#9720) Co-authored-by: Nick Cooke <[email protected]>
ncooke3
added a commit
that referenced
this pull request
May 4, 2022
* Missing NSObject overrides and tests (#9715) * Fix an issue with StorageUploadTask.resume accidentally using Download. (#9717) (#9718) Co-authored-by: Jon Simantov <[email protected]> * [v9] Improve clarity of zip integration instructions (#9720) * [skip ci] Update zip README * [skip ci] Update zip README (2) * Fix Storage Pod-lib-lint failures on Xcode 13.3.1 (#9748) * [v9] Cherry-pick Firestore build fix for Xcode 13.3.1 into `release-9.0` (#9747) * Fix build errors in Xcode 13.3.1 (#9705) * googletest.cmake: remove GIT_SHALLOW when cloning (#9712) Co-authored-by: Denver Coneybeare <[email protected]> * Bump SPM GTMSessionFetcher dep to 1.7.2 (#9753) Co-authored-by: Paul Beusterien <[email protected]> Co-authored-by: Jon Simantov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The games team discovered we missed a few NSObject overrides in the Storage Swift API port.
This PR adds them back along with tests that we never had.