Skip to content

Merge 9715 and 9720 to master #9719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 28, 2022
Merged

Merge 9715 and 9720 to master #9719

merged 5 commits into from
Apr 28, 2022

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Apr 27, 2022 •
edited
Loading

#9715 and #9720 were implemented on the release-9.0 branch. This PR merges them back to master.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@paulb777 paulb777 changed the title Merge 9715 to master Merge 9715 and 9720 to master Apr 27, 2022
@google-oss-bot
Copy link

google-oss-bot commented Apr 27, 2022 •
edited
Loading

Size Report 1

Affected Products

  • FirebaseStorage

    TypeBase (5238f50)Merge (c63126f)Diff
    CocoaPods831 kB831 kB+128 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/47nCeP9ysG.html

@paulb777 paulb777 requested a review from ncooke3 April 27, 2022 23:06
ncooke3
ncooke3 approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseStorage-iOS-FirebaseStorage.framework

    Overall coverage changed from ? (5238f50) to 0.00% (056ce24) by ?.

    13 individual files with coverage change

    FilenameBase (5238f50)Merge (056ce24)Diff
    AsyncAwait.swift?0.00%?
    Result.swift?0.00%?
    Storage.swift?0.00%?
    StorageComponent.swift?0.00%?
    StorageDownloadTask.swift?0.00%?
    StorageError.swift?0.00%?
    StorageListResult.swift?0.00%?
    StorageMetadata.swift?0.00%?
    StorageObservableTask.swift?0.00%?
    StorageReference.swift?0.00%?
    StorageTask.swift?0.00%?
    StorageTaskSnapshot.swift?0.00%?
    StorageUploadTask.swift?0.00%?

  • FirebaseStorage-iOS-FirebaseStorageInternal.framework

    Overall coverage changed from ? (5238f50) to 0.00% (056ce24) by ?.

    18 individual files with coverage change

    FilenameBase (5238f50)Merge (056ce24)Diff
    FIRStorage.m?0.00%?
    FIRStorageDeleteTask.m?0.00%?
    FIRStorageDownloadTask.m?0.00%?
    FIRStorageErrors.m?0.00%?
    FIRStorageGetDownloadURLTask.m?0.00%?
    FIRStorageGetMetadataTask.m?0.00%?
    FIRStorageListResult.m?0.00%?
    FIRStorageListTask.m?0.00%?
    FIRStorageMetadata.m?0.00%?
    FIRStorageObservableTask.m?0.00%?
    FIRStoragePath.m?0.00%?
    FIRStorageReference.m?0.00%?
    FIRStorageTask.m?0.00%?
    FIRStorageTaskSnapshot.m?0.00%?
    FIRStorageTokenAuthorizer.m?0.00%?
    FIRStorageUpdateMetadataTask.m?0.00%?
    FIRStorageUploadTask.m?0.00%?
    FIRStorageUtils.m?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZutciXXK5n.html

@paulb777 paulb777 merged commit 1fc4e50 into master Apr 28, 2022
@paulb777 paulb777 deleted the pb-merge9 branch April 28, 2022 00:02
@firebase firebase locked and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
api: storage release-tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @google-oss-bot @ncooke3