Fixes #1450: ThenableReference should extend Promise, not PromiseLike. (#1462)

mikelehen · web-flow · commit 0b42ff8bb872 · 2019-01-09T10:18:38.000-08:00
Since we implement .catch(), we should extend Promise.
diff --git a/packages/database-types/index.d.ts b/packages/database-types/index.d.ts
@@ -125,7 +125,7 @@ export interface ServerValue {
   };
 }
 
-export interface ThenableReference extends Reference, PromiseLike<Reference> {}
+export interface ThenableReference extends Reference, Promise<Reference> {}
 
 export function enableLogging(
   logger?: boolean | ((a: string) => any),
diff --git a/packages/firebase/index.d.ts b/packages/firebase/index.d.ts
@@ -585,7 +585,7 @@ declare namespace firebase.database {
 
   interface ThenableReference
     extends firebase.database.Reference,
-      PromiseLike<any> {}
+      Promise<Reference> {}
 
   function enableLogging(
     logger?: boolean | ((a: string) => any),

Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ export interface ServerValue {`
`125`	`125`	`};`
`126`	`126`	`}`
`127`	`127`
`128`		`-export interface ThenableReference extends Reference, PromiseLike<Reference> {}`
	`128`	`+export interface ThenableReference extends Reference, Promise<Reference> {}`
`129`	`129`
`130`	`130`	`export function enableLogging(`
`131`	`131`	`logger?: boolean \| ((a: string) => any),`