Fixes #1450: ThenableReference should extend Promise, not PromiseLike. #1462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelehen
requested review from
hiranya911,
hsubox76 and
schmidt-sebastian
as code owners
Since we implement .catch(), we should extend Promise.
mikelehen
force-pushed
the
mikelehen/fix-thenablereference-type
branch
from
eaabcc1 to
74b4575
Compare
Feiyang1
approved these changes
Jan 9, 2019
jsayol
added a commit
to jsayol/firebase-admin-node
that referenced
this pull request
Apr 5, 2019
ThenableReference implements a `.catch()` method, but `ref.push(...).catch(...)` generates a TypeScript error, since neither the `Reference` nor `PromiseLike` interfaces have that method. This change was [already done on the JS SDK](firebase/firebase-js-sdk#1462) back in January, this PR simply puts the admin SDK in line with it.
jsayol
added a commit
to jsayol/firebase-admin-node
that referenced
this pull request
Apr 5, 2019
ThenableReference implements a `.catch()` method, but `ref.push(...).catch(...)` generates a TypeScript error, since neither the `Reference` nor `PromiseLike` interfaces have that method. This change was [already done on the JS SDK](firebase/firebase-js-sdk#1462) back in January, and this PR simply puts the admin SDK back in line with it.
jsayol
added a commit
to jsayol/firebase-admin-node
that referenced
this pull request
Apr 18, 2019
ThenableReference implements a `.catch()` method, but `ref.push(...).catch(...)` generates a TypeScript error, since neither the `Reference` nor `PromiseLike` interfaces have that method. This change was [already done on the JS SDK](firebase/firebase-js-sdk#1462) back in January, and this PR simply puts the admin SDK back in line with it.
jsayol
added a commit
to jsayol/firebase-admin-node
that referenced
this pull request
Apr 18, 2019
ThenableReference implements a `.catch()` method, but `ref.push(...).catch(...)` generates a TypeScript error, since neither the `Reference` nor `PromiseLike` interfaces have that method. This change was [already done on the JS SDK](firebase/firebase-js-sdk#1462) back in January, and this PR simply puts the admin SDK back in line with it.
hiranya911
pushed a commit
to firebase/firebase-admin-node
that referenced
this pull request
Apr 24, 2019
ThenableReference implements a `.catch()` method, but `ref.push(...).catch(...)` generates a TypeScript error, since neither the `Reference` nor `PromiseLike` interfaces have that method. This change was [already done on the JS SDK](firebase/firebase-js-sdk#1462) back in January, and this PR simply puts the admin SDK back in line with it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we implement .catch(), we should extend Promise.