Support BrowserPlatforms with no window or document #1140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wilhuff @schmidt-sebastian Would like to know is this change deployed? Thank you! |
|
@jeffreyleeon This change will out with the next release, which should be soon. I can't promise an exact date, but we try to release weekly. |
|
+1 on needing this deployed, seems a blocker to using Firebase with any app created with Understand it's in queue and will be soon, just registering a +1 that I'm blocked on this 👍 EDIT: As @Bunkerbewohner mentions in this issue (#1138), this bug only came about in Firebase 5.4.0. Installing [email protected] fixes this issue and unblocks me (and hopefully anyone else reading this). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expand the checks of #1139 to support platforms where merely accessing "document" or "window" is an error condition (as is the case in Node for example).
Fixes #1138 which uses ReactNative.