Checking for UnknownDocument #1174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| return maybeDoc === null || maybeDoc instanceof NoDocument; | ||
| } | ||
| return this.exists === maybeDoc instanceof Document; |
There was a problem hiding this comment.
Note that prettier ate the parenthesis around maybeDoc instanceof Document.
schmidt-sebastian
force-pushed
the
mrschmidt-unknowndocument
branch
from
6ab4043 to
f662d48
Compare
schmidt-sebastian
requested review from
gsoltis,
rsgowman,
var-const and
zxu123
as code owners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add handling of UnknownDocument in places where we check for
instanceof NoDocument.