Improve AppError typings #1645
Merged
Improve AppError typings #1645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmermerkaya
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
|
Thanks very much! I updated it to use enum in the app-v6 branch. Also PR is welcomed ! <3 |
Feiyang1
approved these changes
Mar 28, 2019
|
Oh awesome, haha I didn't even realize we had that branch. I guess there's no need to switch to enums here since this will go away soon enough. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Randomly noticed this while looking into FirebaseError. This way TS will complain if the
errorsobject is missing anyAppErrorstring, or contains a string that is not inAppError.I'd still recommend using a
const enuminstead of a union type asAppErrorthough.