Skip to content

Use a const enum for ErrorCode #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2019
Merged

Use a const enum for ErrorCode #1646

merged 2 commits into from
Mar 28, 2019

Conversation

mmermerkaya
Copy link
Contributor

Following my own advice from #1645 🙂

dwoffinden
dwoffinden approved these changes Mar 28, 2019
View reviewed changes
@dwoffinden dwoffinden self-requested a review March 28, 2019 17:19
@mmermerkaya mmermerkaya changed the title Use a const enum for ErrorCodes Use a const enum for ErrorCode Mar 28, 2019
@mmermerkaya mmermerkaya merged commit d97b62c into master Mar 28, 2019
@mmermerkaya mmermerkaya deleted the mmermerkaya-error-enum branch March 28, 2019 18:41
@Feiyang1
Copy link
Member

nice!

@firebase firebase locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwoffinden dwoffinden dwoffinden approved these changes

@pinarx pinarx Awaiting requested review from pinarx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmermerkaya @Feiyang1 @dwoffinden