Remove some object utility functions #1816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmermerkaya
requested review from
Feiyang1,
hiranya911,
hsubox76,
jsdt,
mikelehen and
schmidt-sebastian
as code owners
zijianjoy
force-pushed
the
mmermerkaya-refactor-obj
branch
from
407a59a to
eed06e8
Compare
zijianjoy
force-pushed
the
mmermerkaya-remove-obj
branch
from
a1508be to
45bb39a
Compare
wilhuff
force-pushed
the
mmermerkaya-remove-obj
branch
from
45bb39a to
a1508be
Compare
mmermerkaya
force-pushed
the
mmermerkaya-remove-obj
branch
from
a1508be to
65cf0be
Compare
mmermerkaya
requested review from
alikn,
andirayo,
davideast,
dwoffinden,
jamesdaniels,
pinarx,
ryanpbrewster,
scottcrossen,
yuchenshi and
zijianjoy
as code owners
mmermerkaya
force-pushed
the
mmermerkaya-refactor-obj
branch
2 times, most recently
from
cd6f0dc to
69c6876
Compare
mmermerkaya
force-pushed
the
mmermerkaya-remove-obj
branch
from
65cf0be to
944fcee
Compare
mmermerkaya
removed request for
jamesdaniels,
mikelehen,
dwoffinden,
jsdt,
alikn and
andirayo
mmermerkaya
removed request for
davideast,
pinarx,
ryanpbrewster,
scottcrossen,
yuchenshi and
zijianjoy
schmidt-sebastian
suggested changes
May 31, 2019
mmermerkaya
force-pushed
the
mmermerkaya-remove-obj
branch
from
944fcee to
e1bd292
Compare
mmermerkaya
force-pushed
the
mmermerkaya-refactor-obj
branch
from
69c6876 to
0c4594a
Compare
mmermerkaya
force-pushed
the
mmermerkaya-remove-obj
branch
from
e1bd292 to
94cf9f0
Compare
mmermerkaya
force-pushed
the
mmermerkaya-remove-obj
branch
from
94cf9f0 to
997a26d
Compare
|
I'm merging this to the other PR so that we can submit both of them together. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces some functions from
@firebase/utilwith native functions.