Fix SauceLabs tests #1920
Merged
Fix SauceLabs tests #1920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmermerkaya
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
performance also doesn't work in IE because of a syntax error I don't know what is causing it yet. |
|
Thanks for figuring all this out! Sounds like there's nothing for me to do. 😄 |
Feiyang1
force-pushed
the
mmermerkaya-fix-saucelabs
branch
from
754989d to
c42239e
Compare
Feiyang1
reviewed
Jul 12, 2019
| const TYPED_ARRAY_REPRESENTATION = new TextEncoder().encode('hello world'); | ||
| const BASE_64_REPRESENTATION = btoa('hello world'); | ||
| const str = 'hello world'; | ||
| const TYPED_ARRAY_REPRESENTATION = new Uint8Array(str.length); |
There was a problem hiding this comment.
Changed so it works in IE11 without TextEncoder polyfill, though there still are many tests failing in IE11 (due to indexedDB?). Is installations designed to work in IE11 ? @mmermerkaya
There was a problem hiding this comment.
Installations should work in IE11. I have not received any bug reports about it not working in IE11.
Feiyang1
changed the title
* stub storage differently so tests work in Firefox and IE * [AUTOMATED]: Prettier Code Styling * rewrite test setup * [AUTOMATED]: Prettier Code Styling
Feiyang1
force-pushed
the
mmermerkaya-fix-saucelabs
branch
from
2f2fe61 to
29c054b
Compare
|
The PR fixes the saucelabs testing infrastructure and unit tests for some SDKs. |
hsubox76
approved these changes
Sep 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.