stub storage differently so tests work in Firefox and IE #1940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alikn
reviewed
Jul 3, 2019
packages/performance/src/services/remote_config_service.test.ts
Outdated
Show resolved
Hide resolved
| storageGetItemFakeFactory( | ||
| EXPIRY_LOCAL_STORAGE_VALUE, | ||
| STRINGIFIED_CONFIG | ||
| ) |
There was a problem hiding this comment.
can we put the stubbing part in a function which returns the stub? Something like the pattern discussed here: go/sifers.
alikn
approved these changes
Jul 9, 2019
Feiyang1
added a commit
that referenced
this pull request
Sep 18, 2019
* stub storage differently so tests work in Firefox and IE * [AUTOMATED]: Prettier Code Styling * rewrite test setup * [AUTOMATED]: Prettier Code Styling
Feiyang1
pushed a commit
that referenced
this pull request
Sep 18, 2019
* Fix SauceLabs tests for Installations and Performance * add resolveJsonModule * stub storage differently so tests work in Firefox and IE (#1940) * stub storage differently so tests work in Firefox and IE * [AUTOMATED]: Prettier Code Styling * rewrite test setup * [AUTOMATED]: Prettier Code Styling * change compilation target to es5 * fix IE11 errors * fix storage IE11 tests * fix util IE11 test * fix performance IE11 tests * make installations run in IE * fix integration/typescript tests in saucelabs * [AUTOMATED]: Prettier Code Styling * revert change that doesn't work * fix lint * add babel loader
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.