Make initial view test actually use index-free queries #2051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated this PR with a test that actually now breaks on Android (since we need to refill the query from cache when it is resumed) |
schmidt-sebastian
force-pushed
the
mrschmidt/breakandroid
branch
from
d1a640d to
2b07278
Compare
schmidt-sebastian
added a commit
to firebase/firebase-android-sdk
that referenced
this pull request
Aug 9, 2019
schmidt-sebastian
added a commit
to firebase/firebase-android-sdk
that referenced
this pull request
Aug 9, 2019
mikelehen
pushed a commit
that referenced
this pull request
Aug 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the spec test I wrote on Friday to actually use index-free queries. Note that I still have all tests passing even with this change.