Don't persist documents that we already have #2099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var-const
suggested changes
Aug 21, 2019
| @@ -580,22 +558,21 @@ export class LocalStore { | |||
| // can synthesize remote events when we get permission denied errors while | |||
| // trying to resolve the state of a locally cached document that is in | |||
| // limbo. | |||
| const remoteVersion = remoteEvent.snapshotVersion; | |||
| if (!remoteVersion.isEqual(SnapshotVersion.MIN)) { | |||
| if (!snapshotVersion.isEqual(SnapshotVersion.MIN)) { | |||
There was a problem hiding this comment.
Question: why doesn't this change apply to the Android port?
There was a problem hiding this comment.
This is just a rename to which allows me to use an object shorthand notation (instead of {snapshotVersion:remoteVersion} I can now use {snapshotVersion}.
There was a problem hiding this comment.
Addressed your feedback (ported the changes for Android).
Since I was mucking around in the same codepath I also pulled in firebase/firebase-android-sdk#721
| @@ -580,22 +558,21 @@ export class LocalStore { | |||
| // can synthesize remote events when we get permission denied errors while | |||
| // trying to resolve the state of a locally cached document that is in | |||
| // limbo. | |||
| const remoteVersion = remoteEvent.snapshotVersion; | |||
| if (!remoteVersion.isEqual(SnapshotVersion.MIN)) { | |||
| if (!snapshotVersion.isEqual(SnapshotVersion.MIN)) { | |||
There was a problem hiding this comment.
This is just a rename to which allows me to use an object shorthand notation (instead of {snapshotVersion:remoteVersion} I can now use {snapshotVersion}.
var-const
approved these changes
Aug 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the handling of remote documents to skip any document updates for document versions that we already have cached. To keep the code readable, I removed the concept of
authoritativeUpdates(as discussed in the API discussion phase of Sprint planning).