Skip to content

[database] Add request to optionalDependencies #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

styfle
Copy link

@styfle styfle commented Sep 4, 2019

The database package uses the request dependency but doesn't include it in package.json.

See this line that calls require('request'):

(FirebaseIFrameScriptHolder as any).request = /** @type {function({url: string, forever: boolean}, function(Error, number, string))} */ require('request');

This adds request to the optionalDependencies (perhaps it should be under dependencies?)

I did not create an issue because it's easier to discuss with the code in this PR 😄

@@ -22,6 +22,9 @@
},
"license": "Apache-2.0",
"peerDependencies": {},
"optionalDependencies": {
"request": "*"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you prefer "2.x" instead of asterisk?

@mikelehen
Copy link
Contributor

Thanks for the PR! Your change looks reasonable, but I'm discussing with a colleague and I think we may opt to just delete this code. It's not really used at this point. Hang tight.

@styfle
Copy link
Author

styfle commented Sep 4, 2019

@mikelehen That sounds good too, thanks!

Feel free to close this PR if you need to.

@mikelehen
Copy link
Contributor

Moving forward with the delete: #2144

So I'll close this but we do appreciate you brining this to our attention. 😀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants