Remove nodePatches.ts hackery. #2144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This had some very stale code to: 1. Make it possible to use long-polling instead of WebSockets from the Node.JS SDK. This existed purely for testing purposes, wasn't reliable, and hasn't been used in ages. 2. Work around a bad Node.JS bug that was fixed 6 years ago (nodejs/node-v0.x-archive#6506).
schmidt-sebastian
approved these changes
Sep 4, 2019
|
Changelog added. |
styfle
approved these changes
Sep 5, 2019
schmidt-sebastian
approved these changes
Sep 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This had some very stale code to: