Change the order of checks in applyRemoteEvent() #2176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
force-pushed
the
mrschmidt/fixregression
branch
from
1cd68b1 to
402fd3b
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/fixregression
branch
from
402fd3b to
3ec6996
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/fixregression
branch
from
3ec6996 to
cbf0abe
Compare
mikelehen
approved these changes
Sep 16, 2019
| // assert( | ||
| // !SnapshotVersion.MIN.isEqual(remoteEvent.snapshotVersion), | ||
| // 'Cannot add a document when the remote version is zero' | ||
| // ); |
There was a problem hiding this comment.
What do you think of adding this now but as a non-fatal error log statement that suggests people file a github issue (or maybe we should open a tracking issue now and just ask people to add a comment, just in case a massive number of people hit the log statement)? That would give us some extra confidence that we won't hit issues when we add the assert for real.
There was a problem hiding this comment.
That's a great idea. I changed this to a logline right now, and hope that people will flock to GitHub if they see this. We probably want to do the same from Android if we don't get reproduction steps before the next code freeze.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a chance that a limbo resolution fails for a document that no longer exists, we could get into a state where we write a document into the RemoteDocumentCache with a snapshot version of zero. By re-ordering the statements, we make sure this does not happen
Port of firebase/firebase-android-sdk#802