Add test for NoDocument assert #2205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for the assert that caused the Index-Free rollback on Android (b/141011925).
The customer got back to me (in person at the Firebase Summit) and their stacktrace is actually from MemoryPersistence. With MemoryPersistence it is actually much more likely to hit the scenario that we discussed as the possible culprit (in LocalStore.applyRemoteEvent):
With EagerGC, existingDoc is null if we already unlistened from the query that originally returned it when the Limbo resolution fails (or if we remove a mutation that depended on it).
The test hits the assert in the original code, but passes since we merged #2176