Tidy firebase-messaging Tests #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fore and after each test
jshcrowthe
previously approved these changes
Oct 18, 2017
packages/messaging/package.json
Outdated
| @@ -7,6 +7,7 @@ | |||
| "scripts": { | |||
| "dev": "gulp dev", | |||
| "test": "karma start --single-run", | |||
| "test:manual": "karma start --browsers=Chrome --auto-watch", | |||
There was a problem hiding this comment.
Can we call this test:debug? Just to be consistent with other debug scripts.
jshcrowthe
approved these changes
Oct 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tidies up the clean in before and after of tests and makes use of sinon sandboxes rather than manually tracking stubs etc.