Update the test:setup script to configure firestore settings #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauntface
approved these changes
Oct 19, 2017
There was a problem hiding this comment.
Changes LGTM. Did I miss a linting or prettier or ... step in my previous PR?
Also request the test setup - is there any way to test that it's setup correctly and tell the developer to change if it's not?
i.e. write to firestore, catch the error and give a useful error message on what to do?
|
Also looks like the messaging integration tests are failling, has this been an ongoing issue? they passed for my previous PR (I think) |
|
@gauntface I've seen your integration tests time out from time to time. It is really inconsistent. We can try bumping the timeouts? |
|
timeouts and retries should make it more stable. Happy to take a look in a seperate PR unless you want to try in this one. |
|
Lets do it in a separate one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems some styling things got missed by another PR (i.e. #232)
This just augments the
test:setupscript to properly configure firestore