Remove enum overhead #2697
Merged
Remove enum overhead #2697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the TypeScript style guides recommends against this, but the reasons do not apply to our codebase. |
|
FYI @Feiyang1 |
wilhuff
reviewed
Feb 29, 2020
| @@ -51,7 +51,7 @@ export class EventManager implements SyncEngineListener { | |||
| q.canonicalId() | |||
| ); | |||
|
|
|||
| private onlineState: OnlineState = 'Unknown'; | |||
| private onlineState: OnlineState = OnlineState.Unknown; | |||
There was a problem hiding this comment.
You can now probably move the explicit type here (i.e. restore it back to)
private onlineState = OnlineState.Unknown;?
There was a problem hiding this comment.
Done. Note that this was part of a straight revert.
| /** | ||
| * The Firestore client is in an unknown online state. This means the client | ||
| * is either not actively trying to establish a connection or it is currently | ||
| * trying to establish a connection, but it has not succeeded or failed yet. | ||
| * Higher-level components should not operate in offline mode. | ||
| */ | ||
| | 'Unknown' | ||
| Unknown = 'Unknown', |
There was a problem hiding this comment.
Do we need the strings in here anymore? Can these just be numeric?
There was a problem hiding this comment.
The string values are persisted in WebStorage (but it is mostly transient data). I added a comment to explain this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the overhead that Enums introduce in TypeScript by changing our enums to "const enums" which can be inlined: https://www.typescriptlang.org/docs/handbook/enums.html#const-enums
This also reverts some of the changes that were made to the OnlineState enum and uses the same solution.
Size before: 318393 bytes (90882 gzipped)
Size after: 315811 bytes (89863 gzipped - 1.2%)