Modular Export Binary Size Analysis - WIP #3280

XuechunHou · 2020-06-25T01:01:18Z

Stage a PR to track progress of modular export binary size calculator project

Initial package structure--copied from packages/template, but with tests working

Add mock fetch library for tests

* Add core types & error map * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: License Headers * User should be an interface for now we can make an implementation class later

* User should be an interface for now we can make an implementation class later * Add API call to signUp * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: License Headers * Update tests to test a little more * [AUTOMATED]: Prettier Code Styling

* Initial user object implementation

* Consolidate mock auth / add user test helper * [AUTOMATED]: Prettier Code Styling * Fix tests

* User should be an interface for now we can make an implementation class later * Add API call to signUp * [AUTOMATED]: Prettier Code Styling * Update tests to test a little more * Add remaining API methods to auth-next * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: License Headers * Add more tests to account API methods * Pass in SDK version & correctly send GET request params * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: Prettier Code Styling * Fix import ordering * Minor formatting change * [AUTOMATED]: Prettier Code Styling

* Add support for API timeouts to auth-next * PR feedback * [AUTOMATED]: Prettier Code Styling

* Add version helper to auth-next * [AUTOMATED]: Prettier Code Styling * PR feedback

…n} (#2908)

* Add fetchSignInMethodsForEmail to auth-next * [AUTOMATED]: Prettier Code Styling * PR Feedback * [AUTOMATED]: Prettier Code Styling

* Add sendEmailVerification to auth-next * [AUTOMATED]: Prettier Code Styling * Add missing test * Remove GetOobCodeRequestType in favor of Operation

* Add sendEmailVerification to auth-next * [AUTOMATED]: Prettier Code Styling * Remove GetOobCodeRequestType in favor of Operation * Add password reset methods to auth-next * [AUTOMATED]: Prettier Code Styling * PR Feedback * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: Prettier Code Styling * Resolve merge conflicts * [AUTOMATED]: Prettier Code Styling

* Use queryString from firebase/util instead of homebrew one * [AUTOMATED]: Prettier Code Styling * PR Feedback * [AUTOMATED]: Prettier Code Styling

* Add conditional delays to auth-next * [AUTOMATED]: Prettier Code Styling * Use typescript asserts keyword for typesafe assertions * [AUTOMATED]: Prettier Code Styling * Rebase conflicts & PR feedback * More PR Feedback * Strip debug asserts from prod builds * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: API Reports * Fix logic in assertion * Revert merge artifacts * PR Feedback

* Add sendSignInWithEmail links * [AUTOMATED]: Prettier Code Styling * PR Feedback * PR Feedback

* Standardize auth-next style - prefix directory for test blocks - use kebab style for test values to make them visually distinct from keys - use '#' to prefix instance methods and '.' for class methods - prefix all private exported methods with '_' * [AUTOMATED]: Prettier Code Styling * Two more cases I missed

Added React Native persistence class

* Update internal types to work with external types * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: License Headers * PR feedback * [AUTOMATED]: Prettier Code Styling

…#3078) * Further refactoring of auth types. Add public exports to src/index.ts * Add app-exp to devDependencies * PR feedback

* user.delete() implementation * [AUTOMATED]: Prettier Code Styling * PR feedback * PR feedback

* Add signInWithCredential to auth-next * [AUTOMATED]: Prettier Code Styling * Add conditional delays to auth-next (#2934) * Add conditional delays to auth-next * [AUTOMATED]: Prettier Code Styling * Use typescript asserts keyword for typesafe assertions * [AUTOMATED]: Prettier Code Styling * Rebase conflicts & PR feedback * More PR Feedback * Strip debug asserts from prod builds * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: API Reports * Fix logic in assertion * Revert merge artifacts * PR Feedback * Cleanup & PR Feedback * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: License Headers * Add more tests * [AUTOMATED]: Prettier Code Styling * Rebase conflicts * Cleanup type exports * PR feedback * Declare abstract class abstractly

…into size-analysis-repo

package.json

Feiyang1 · 2020-07-27T23:54:46Z

repo-scripts/size-analysis/README.md

+
+### To Do Analysis On All Firebase-Exp Modules
+
+$firebase-js-sdk/repo-scripts/size-analysis  `ts-node-script analysis.ts  -o <path to output DIRECTORY>`


Can you please add a section on how to use it programmatically ?

repo-scripts/size-analysis/analysis-helper.ts

repo-scripts/size-analysis/size-analysis.test.ts

packages/firestore/scripts/extract-api.js

repo-scripts/size-analysis/analysis-helper.ts

…om firebase/util

…base-js-sdk into size-analysis-repo

Feiyang1 · 2020-08-05T17:30:00Z

repo-scripts/size-analysis/size-analysis.test.ts

+    ]);
+  });
+
+  it('test re-exported variable extractions from same module', () => {


Can you break it out into 2 tests - named reexports and start reexport?

Feiyang1 · 2020-08-05T18:00:00Z

repo-scripts/size-analysis/size-analysis.test.ts

+  });
+
+  it('should not throw error when given path does not pre-exist', () => {
+    const aDir = resolve('./a-dir/a-sub-dir');


This relies on the assumption that the tests run in order where the previous test creates the dir, which may not be true. This test should create the folder in its own body. The previous test should clean up once it's finished.

Feiyang1 · 2020-08-05T18:04:47Z

repo-scripts/size-analysis/size-analysis.test.ts

+  let extractedDeclarations: MemberList;
+  before(() => {
+    testModuleDtsFile = retrieveTestModuleDtsFile();
+    extractedDeclarations = extractDeclarations(testModuleDtsFile);


Can you add tests for extractDeclarations where the input is a js bundle?

…rn a declaration list

…base-js-sdk into size-analysis-repo

…into size-analysis-repo

…base-js-sdk into size-analysis-repo

Feiyang1 · 2020-08-21T21:42:12Z

Replaced by #3588

sam-gc and others added 30 commits May 19, 2020 09:30

Initial submit of auth-next framework (#2851)

227941c

Initial package structure--copied from packages/template, but with tests working

Add mock fetch helper (#2878)

372d7c0

Add mock fetch library for tests

Add core types & error map to auth-exp (#2890)

b359033

* Add core types & error map * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: License Headers * User should be an interface for now we can make an implementation class later

Add initial user object implementation (#2896)

a852021

* Initial user object implementation

Consolidate mock auth object, add user object (#2906)

0ae5fa5

* Consolidate mock auth / add user test helper * [AUTOMATED]: Prettier Code Styling * Fix tests

Add support for API timeouts to auth-next (#2915)

6044bbc

* Add support for API timeouts to auth-next * PR feedback * [AUTOMATED]: Prettier Code Styling

Add version helpers to auth-next (#2910)

22405fd

* Add version helper to auth-next * [AUTOMATED]: Prettier Code Styling * PR feedback

Add persistence layer: index db, in memory, and browser{local, sessio…

36632e9

…n} (#2908)

Add fetchSignInMethodsForEmail to auth-next (#2924)

e6bfb6a

* Add fetchSignInMethodsForEmail to auth-next * [AUTOMATED]: Prettier Code Styling * PR Feedback * [AUTOMATED]: Prettier Code Styling

Add sendEmailVerification to auth-next (#2926)

8a178d0

* Add sendEmailVerification to auth-next * [AUTOMATED]: Prettier Code Styling * Add missing test * Remove GetOobCodeRequestType in favor of Operation

Add a persistence manager class (#2925)

a3a7281

Added react native build target (#2947)

c5174ab

use queryString helper in auth-next (#2936)

7aead1c

* Use queryString from firebase/util instead of homebrew one * [AUTOMATED]: Prettier Code Styling * PR Feedback * [AUTOMATED]: Prettier Code Styling

Initial auth object implementation + initializeAuth() (#2932)

290d97d

use app-exp in the build:deps script

1c4734b

Add sendSignInWithEmail to auth-next (#2960)

9342be4

* Add sendSignInWithEmail links * [AUTOMATED]: Prettier Code Styling * PR Feedback * PR Feedback

Add auth listener implementation, add user.reload() (#2961)

deab6e3

Add refresh token endpoint + implementation to token manager (#2975)

30b7dab

Add react native persistence class (#2955)

c3a82f6

Added React Native persistence class

Add getIdTokenResult implementation (#3014)

9b26963

Update internal types to work with external types (#3075)

12e7465

* Update internal types to work with external types * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: License Headers * PR feedback * [AUTOMATED]: Prettier Code Styling

Further refactoring of auth types. Add public exports to src/index.ts (…

b278cea

…#3078) * Further refactoring of auth types. Add public exports to src/index.ts * Add app-exp to devDependencies * PR feedback

user.delete() implementation (#3072)

7b297c5

* user.delete() implementation * [AUTOMATED]: Prettier Code Styling * PR feedback * PR feedback

Use auth impl object instead of mock auth object (#3098)

e71513a

Merge branch 'master' of https://github.com/firebase/firebase-js-sdk …

2ab2ceb

…into size-analysis-repo

Feiyang1 suggested changes Jul 28, 2020

View reviewed changes

addressed PR comments

de485d3

Feiyang1 reviewed Aug 3, 2020

View reviewed changes

XuechunHou and others added 9 commits August 3, 2020 13:56

addressed PR comments, replaced custom deepCopy function with that fr…

ed7a034

…om firebase/util

reverted prettier changes

48178dd

reverted prettier changes

f0a75eb

addressed PR comments

584fea3

addressed PR comments

79f9747

pulled from master

fb7a164

update package.json

52ee009

changed rollup plugin import location

457106c

Merge branch 'size-analysis-repo' of https://github.com/firebase/fire…

cd23a30

…base-js-sdk into size-analysis-repo

Feiyang1 reviewed Aug 5, 2020

View reviewed changes

XuechunHou and others added 13 commits August 5, 2020 13:58

modified handleExportStatementsWithoutFromClause function to not retu…

32548ce

…rn a declaration list

fixed rmDirSync issue

7105985

refactor testing

9fed25f

pulled from master

18c120d

Merge branch 'size-analysis-repo' of https://github.com/firebase/fire…

5334cf2

…base-js-sdk into size-analysis-repo

added tests on js bundle files

489e832

removed unnecessary files

9370e09

Update test-changed workflow checkout step (#3580)

41ed6f2

Merge branch 'master' of https://github.com/firebase/firebase-js-sdk …

2c99c44

…into size-analysis-repo

set longer timeout for testing

b600cd5

updated comments and error message

a0e69d8

minor updates

f968e0b

Merge branch 'size-analysis-repo' of https://github.com/firebase/fire…

6625069

…base-js-sdk into size-analysis-repo

XuechunHou closed this Aug 7, 2020

firebase locked and limited conversation to collaborators Sep 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Modular Export Binary Size Analysis - WIP #3280

Modular Export Binary Size Analysis - WIP #3280

Uh oh!

XuechunHou commented Jun 25, 2020 •

edited

Loading

Uh oh!

Uh oh!

Feiyang1 Jul 27, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Feiyang1 Aug 5, 2020

Uh oh!

Feiyang1 Aug 5, 2020

Uh oh!

Feiyang1 Aug 5, 2020

Uh oh!

Feiyang1 commented Aug 21, 2020

Uh oh!

Uh oh!


		### To Do Analysis On All Firebase-Exp Modules

		$firebase-js-sdk/repo-scripts/size-analysis `ts-node-script analysis.ts -o <path to output DIRECTORY>`

Modular Export Binary Size Analysis - WIP #3280

Modular Export Binary Size Analysis - WIP #3280

Uh oh!

Conversation

XuechunHou commented Jun 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Feiyang1 Jul 27, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Feiyang1 Aug 5, 2020

Choose a reason for hiding this comment

Uh oh!

Feiyang1 Aug 5, 2020

Choose a reason for hiding this comment

Uh oh!

Feiyang1 Aug 5, 2020

Choose a reason for hiding this comment

Uh oh!

Feiyang1 commented Aug 21, 2020

Uh oh!

Uh oh!

XuechunHou commented Jun 25, 2020 •

edited

Loading