Skip to content

WIP LocalStore-only queries #3425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

schmidt-sebastian
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@changeset-bot
Copy link

changeset-bot bot commented Jul 16, 2020

💥 No Changeset

Latest commit: d1064a8

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 16, 2020

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (ee33ebf) Head (39322b3) Diff
    browser 247 kB 247 kB -448 B (-0.2%)
    esm2017 194 kB 194 kB -255 B (-0.1%)
    main 495 kB 497 kB +1.60 kB (+0.3%)
    module 245 kB 244 kB -517 B (-0.2%)
    react-native 194 kB 194 kB -255 B (-0.1%)
  • @firebase/firestore/exp

    Type Base (ee33ebf) Head (39322b3) Diff
    main 401 kB 406 kB +4.85 kB (+1.2%)
  • @firebase/firestore/lite

    Type Base (ee33ebf) Head (39322b3) Diff
    main 125 kB 125 kB +412 B (+0.3%)
  • @firebase/firestore/memory

    Type Base (ee33ebf) Head (39322b3) Diff
    browser 185 kB 185 kB +506 B (+0.3%)
    esm2017 145 kB 145 kB +218 B (+0.2%)
    main 364 kB 366 kB +1.82 kB (+0.5%)
    module 183 kB 183 kB +449 B (+0.2%)
    react-native 145 kB 145 kB +218 B (+0.2%)
  • firebase

    Type Base (ee33ebf) Head (39322b3) Diff
    firebase-firestore.js 285 kB 285 kB -627 B (-0.2%)
    firebase-firestore.memory.js 224 kB 225 kB +415 B (+0.2%)
    firebase.js 820 kB 820 kB -621 B (-0.1%)

Test Logs

@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/splitlocalstore branch from 529a627 to d1064a8 Compare July 17, 2020 22:36
@schmidt-sebastian schmidt-sebastian changed the title Tree-shake LocalStore WIP Tree-shake LocalStore Jul 17, 2020
@schmidt-sebastian schmidt-sebastian changed the title WIP Tree-shake LocalStore WIP LocalStore-only queries Jul 17, 2020
@firebase firebase locked and limited conversation to collaborators Aug 29, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/splitlocalstore branch November 9, 2020 22:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants