Extract Offline-only component provider #3460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💥 No ChangesetLatest commit: 2ccff75 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs
|
schmidt-sebastian
force-pushed
the
mrschmidt/components
branch
from
26db8f5 to
3da634e
Compare
schmidt-sebastian
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
schmidt-sebastian
force-pushed
the
mrschmidt/components
branch
2 times, most recently
from
a926099 to
489fcb4
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/components
branch
from
489fcb4 to
2b021e7
Compare
var-const
approved these changes
Jul 24, 2020
packages/firestore/package.json
Outdated
| @@ -18,7 +18,7 @@ | |||
| "dev": "rollup -c -w", | |||
| "lint": "eslint -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'", | |||
| "lint:fix": "eslint --fix -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'", | |||
| "prettier": "prettier --write '*.js' '{,!(dist)}/**/*.ts'", | |||
| "prettier": "prettier --write '*.js' '*.ts' '{,!(dist)}/**/*.ts'", | |||
There was a problem hiding this comment.
Question: what's the reason for this addition? Shouldn't the glob on the right cover it?
There was a problem hiding this comment.
I tried to figure this out with https://globster.xyz/, but it seems to slightly disagree with what we have. I think '{,!(dist)}/**/*.ts' doesn't match since it requires at least one level of nesting.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next PR in the infinite series that will eventually be #3425
It changes the component providers so that it is possible to only instantiate the components that are needed for cache-only queries.
There are now:
The offline providers provide LocalStore, Persistence and related classes. OnlineComponentProvider provides SyncEngine and RemoteStore (among others).
MultiTabOfflineComponentProvider depends on OnlineComponentProvider. That means that in Multi-Tab mode, even a client that only uses
getDocsFromCachewill bundle RemoteStore and SyncEngine. This is probably what we want though, since it may have to listen to queries from secondary tabs.