Skip to content

Remove all namespace imports #3660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 20, 2020
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

This would unblock #3657 without the API Extractor update.

@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2020

💥 No Changeset

Latest commit: 96fd2eb

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 19, 2020

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (05f8002) Head (5e679c9) Diff
    main 476 kB 476 kB -50 B (-0.0%)
  • @firebase/firestore/exp

    Type Base (05f8002) Head (5e679c9) Diff
    main 468 kB 468 kB -28 B (-0.0%)
  • @firebase/firestore/memory

    Type Base (05f8002) Head (5e679c9) Diff
    main 349 kB 349 kB -76 B (-0.0%)

Test Logs

@@ -0,0 +1,18 @@
/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still need this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, it breaks the TypeScript compile even without the API Extractor.

@schmidt-sebastian schmidt-sebastian merged commit 3b26db4 into master Aug 20, 2020
@firebase firebase locked and limited conversation to collaborators Sep 20, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/nonamespaces branch November 9, 2020 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants