Skip to content

Remove all namespace imports #3660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 20, 2020
Merged

Remove all namespace imports #3660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
73826ad
Remove all namespace imports
schmidt-sebastian Aug 19, 2020
c14fbcc
Lint
schmidt-sebastian Aug 19, 2020
75c6156
Merge branch 'master' into mrschmidt/nonamespaces
schmidt-sebastian Aug 19, 2020
396ff46
Do not double copy Proto files
schmidt-sebastian Aug 19, 2020
09b620c
Remove firestore-type import
schmidt-sebastian Aug 20, 2020
96fd2eb
Merge branch 'master' into mrschmidt/nonamespaces
schmidt-sebastian Aug 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions packages/firestore/rollup.config.browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,18 +28,27 @@ export default [
sourcemap: true
},
plugins: util.es2017Plugins('browser', /* mangled= */ true),
external: util.resolveBrowserExterns
external: util.resolveBrowserExterns,
treeshake: {
moduleSideEffects: false
}
},
{
input: pkg.esm2017,
output: { file: pkg.module, format: 'es', sourcemap: true },
plugins: util.es2017ToEs5Plugins(/* mangled= */ true),
external: util.resolveBrowserExterns
external: util.resolveBrowserExterns,
treeshake: {
moduleSideEffects: false
}
},
{
input: pkg.esm2017,
output: { file: pkg.browser, format: 'cjs', sourcemap: true },
plugins: util.es2017ToEs5Plugins(/* mangled= */ true),
external: util.resolveBrowserExterns
external: util.resolveBrowserExterns,
treeshake: {
moduleSideEffects: false
}
}
];
15 changes: 12 additions & 3 deletions packages/firestore/rollup.config.browser.memory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ export default [
sourcemap: true
},
plugins: util.es2017Plugins('browser', /* mangled= */ true),
external: util.resolveBrowserExterns
external: util.resolveBrowserExterns,
treeshake: {
moduleSideEffects: false
}
},
{
input: path.resolve('./memory', memoryPkg['esm2017']),
Expand All @@ -39,7 +42,10 @@ export default [
sourcemap: true
},
plugins: util.es2017ToEs5Plugins(/* mangled= */ true),
external: util.resolveBrowserExterns
external: util.resolveBrowserExterns,
treeshake: {
moduleSideEffects: false
}
},
{
input: path.resolve('./memory', memoryPkg['esm2017']),
Expand All @@ -49,6 +55,9 @@ export default [
sourcemap: true
},
plugins: util.es2017ToEs5Plugins(/* mangled= */ true),
external: util.resolveBrowserExterns
external: util.resolveBrowserExterns,
treeshake: {
moduleSideEffects: false
}
}
];
10 changes: 8 additions & 2 deletions packages/firestore/rollup.config.node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,18 @@ export default [
'process.env.FIRESTORE_PROTO_ROOT': JSON.stringify('src/protos')
})
],
external: util.resolveNodeExterns
external: util.resolveNodeExterns,
treeshake: {
moduleSideEffects: false
}
},
{
input: pkg['main-esm2017'],
output: [{ file: pkg.main, format: 'cjs', sourcemap: true }],
plugins: util.es2017ToEs5Plugins(),
external: util.resolveNodeExterns
external: util.resolveNodeExterns,
treeshake: {
moduleSideEffects: false
}
}
];
15 changes: 8 additions & 7 deletions packages/firestore/rollup.config.node.memory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

import * as path from 'path';
import replace from 'rollup-plugin-replace';
import copy from 'rollup-plugin-copy-assets';
import memoryPkg from './memory/package.json';

const util = require('./rollup.shared');
Expand All @@ -32,15 +31,14 @@ export default [
},
plugins: [
...util.es2017Plugins('node'),
// Needed as we also use the *.proto files
copy({
assets: ['./src/protos']
}),
replace({
'process.env.FIRESTORE_PROTO_ROOT': JSON.stringify('src/protos')
})
],
external: util.resolveNodeExterns
external: util.resolveNodeExterns,
treeshake: {
moduleSideEffects: false
}
},
{
input: path.resolve('./memory', memoryPkg['main-esm2017']),
Expand All @@ -50,6 +48,9 @@ export default [
sourcemap: true
},
plugins: util.es2017ToEs5Plugins(),
external: util.resolveNodeExterns
external: util.resolveNodeExterns,
treeshake: {
moduleSideEffects: false
}
}
];
5 changes: 4 additions & 1 deletion packages/firestore/rollup.config.rn.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,8 @@ export default {
sourcemap: true
},
plugins: util.es2017Plugins('rn', /* mangled= */ true),
external: util.resolveBrowserExterns
external: util.resolveBrowserExterns,
treeshake: {
moduleSideEffects: false
}
};
5 changes: 4 additions & 1 deletion packages/firestore/rollup.config.rn.memory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,8 @@ export default {
sourcemap: true
},
plugins: util.es2017Plugins('rn', /* mangled= */ true),
external: util.resolveBrowserExterns
external: util.resolveBrowserExterns,
treeshake: {
moduleSideEffects: false
}
};
Loading