Skip to content

Optimize CI tests #3664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Aug 25, 2020
Merged

Optimize CI tests #3664

merged 21 commits into from
Aug 25, 2020

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Aug 19, 2020

  • Removed integration test projects that are not really useful
  • Split Test Modified Packages workflow into the following workflows
    • Test Modified Packages (Test all modified packages except the following ones)
    • Firestore
    • Firestore Integration
    • FCM Integration
    • Auth
    • rxFire, @firebase/testing, @firebase/rules-unit-testing
    • firebase-namespace-integration-test
  • Only build the packages needed for running tests

@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2020

💥 No Changeset

Latest commit: 5b8fd9a

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 19, 2020

Binary Size Report

Affected SDKs

No changes between base commit (39bc71b) and head commit (c385a38).

Test Logs

yarn
- name: yarn build
run: yarn build
- name: Run tests on changed packages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Run tests if firestore package has changed"?

Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not my area of expertise, so I will defer to Christina. Idea LGTM.

hsubox76
hsubox76 previously approved these changes Aug 20, 2020
* build only packages needed for testing

* ignore firebase and firebase-exp

* revert yarn.lock

* test app

* make a separate workflow for firebase namespace test

* early return if no test tasks

* test fcm

* Revert "test fcm"

This reverts commit a0599e8.

* Revert "test app"

This reverts commit 73f817c.

* put auxiliary libs into a separate workflow

* test firebase

* small change

* update yarn.lock

* fix obvious errors

* fix script issues

* run auth tests in a separate workflow

* rename test name to make more sense on Github

* try separating firestore and firestore integration into different workflows
@Feiyang1
Copy link
Member Author

@hsubox76 Created more workflows to speed up CI. Also changed the build step to only build packages needed for testing. Can you please take another look?

@hsubox76 hsubox76 dismissed their stale review August 21, 2020 17:53

Commented on updates

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 24, 2020

Size Analysis Report

Affected Products

No changes between base commit (39bc71b) and head commit (c385a38).

Test Logs

@Feiyang1 Feiyang1 merged commit 96076f0 into master Aug 25, 2020
@Feiyang1 Feiyang1 deleted the fei-integration-workflow branch August 25, 2020 00:23
@firebase firebase locked and limited conversation to collaborators Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants