-
Notifications
You must be signed in to change notification settings - Fork 946
Optimize CI tests #3664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize CI tests #3664
Conversation
💥 No ChangesetLatest commit: 5b8fd9a Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
Binary Size ReportAffected SDKsNo changes between base commit (39bc71b) and head commit (c385a38). Test Logs
|
yarn | ||
- name: yarn build | ||
run: yarn build | ||
- name: Run tests on changed packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Run tests if firestore package has changed"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not my area of expertise, so I will defer to Christina. Idea LGTM.
* build only packages needed for testing * ignore firebase and firebase-exp * revert yarn.lock * test app * make a separate workflow for firebase namespace test * early return if no test tasks * test fcm * Revert "test fcm" This reverts commit a0599e8. * Revert "test app" This reverts commit 73f817c. * put auxiliary libs into a separate workflow * test firebase * small change * update yarn.lock * fix obvious errors * fix script issues * run auth tests in a separate workflow * rename test name to make more sense on Github * try separating firestore and firestore integration into different workflows
@hsubox76 Created more workflows to speed up CI. Also changed the build step to only build packages needed for testing. Can you please take another look? |
Size Analysis ReportAffected ProductsNo changes between base commit (39bc71b) and head commit (c385a38). Test Logs
|
Test Modified Packages
workflow into the following workflows