Build only packages needed for testing #3668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💥 No ChangesetLatest commit: 9703fbb Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
Binary Size ReportAffected SDKsNo changes between base commit (eb55e6f) and head commit (4c7bd71). Test Logs
|
Feiyang1
added a commit
that referenced
this pull request
Aug 25, 2020
* remove unnecessary integration tests * exclude firestore tests from run_changed * fix bug * reduce the scope that triggers global tests * firestore only test changed * Put firestore tests into a separate workflow * rewrote run_changed scripts * fix things * create a separate workflow for FCM integration tests * Build only packages needed for testing (#3668) * build only packages needed for testing * ignore firebase and firebase-exp * revert yarn.lock * test app * make a separate workflow for firebase namespace test * early return if no test tasks * test fcm * Revert "test fcm" This reverts commit a0599e8. * Revert "test app" This reverts commit 73f817c. * put auxiliary libs into a separate workflow * test firebase * small change * update yarn.lock * fix obvious errors * fix script issues * run auth tests in a separate workflow * rename test name to make more sense on Github * try separating firestore and firestore integration into different workflows * run the correct script * refactor test changed * update words * remove unnecessary xvfb-run * add firebase to auth's dependency because auth test depends on it * build correctly * abort if build failed * build appExp * build all for auth
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.