Skip to content

Adding performance to firebase-exp #3830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 24, 2020
Merged

Adding performance to firebase-exp #3830

merged 5 commits into from
Sep 24, 2020

Conversation

jposuna
Copy link
Contributor

@jposuna jposuna commented Sep 22, 2020

Also adding a missing param doc.

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2020

⚠️ No Changeset found

Latest commit: e3d3457

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 23, 2020

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (c20f631) Head (12e43e1) Diff
    browser 249 kB 249 kB +433 B (+0.2%)
    esm2017 196 kB 196 kB +193 B (+0.1%)
    main 483 kB 483 kB +570 B (+0.1%)
    module 246 kB 247 kB +443 B (+0.2%)
    react-native 196 kB 196 kB +193 B (+0.1%)
  • @firebase/firestore/exp

    Type Base (c20f631) Head (12e43e1) Diff
    browser 189 kB 189 kB -436 B (-0.2%)
    main 478 kB 477 kB -963 B (-0.2%)
    module 189 kB 189 kB -436 B (-0.2%)
    react-native 189 kB 189 kB -436 B (-0.2%)
  • @firebase/firestore/lite

    Type Base (c20f631) Head (12e43e1) Diff
    browser 63.8 kB 63.4 kB -436 B (-0.7%)
    main 141 kB 140 kB -963 B (-0.7%)
    module 63.8 kB 63.4 kB -436 B (-0.7%)
    react-native 64.1 kB 63.6 kB -436 B (-0.7%)
  • @firebase/firestore/memory

    Type Base (c20f631) Head (12e43e1) Diff
    browser 186 kB 187 kB +433 B (+0.2%)
    esm2017 147 kB 147 kB +193 B (+0.1%)
    main 356 kB 357 kB +570 B (+0.2%)
    module 184 kB 185 kB +443 B (+0.2%)
    react-native 147 kB 147 kB +193 B (+0.1%)
  • firebase

    Type Base (c20f631) Head (12e43e1) Diff
    firebase-firestore.js 287 kB 287 kB +439 B (+0.2%)
    firebase-firestore.memory.js 226 kB 227 kB +439 B (+0.2%)
    firebase.js 830 kB 831 kB +438 B (+0.1%)

Test Logs

@jposuna jposuna marked this pull request as ready for review September 23, 2020 17:07
@jposuna jposuna requested a review from alikn September 23, 2020 17:07
Copy link
Member

@Feiyang1 Feiyang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except that installations doesn't need to be added to firebase-exp as it is not intended for public usage. We don't expose it in firebase today.

@jposuna jposuna changed the title Adding performance and installations to firebase-exp Adding performance to firebase-exp Sep 24, 2020
@jposuna
Copy link
Contributor Author

jposuna commented Sep 24, 2020

LGTM except that installations doesn't need to be added to firebase-exp as it is not intended for public usage. We don't expose it in firebase today.

Thanks for the info. Reverted the changes to installations.

@jposuna jposuna requested a review from Feiyang1 September 24, 2020 00:27
Copy link
Member

@Feiyang1 Feiyang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need some updates in the package.json file

@jposuna jposuna merged commit 205421e into master Sep 24, 2020
@firebase firebase locked and limited conversation to collaborators Oct 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants