-
Notifications
You must be signed in to change notification settings - Fork 946
Adding performance to firebase-exp #3830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Binary Size ReportAffected SDKs
Test Logs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except that installations
doesn't need to be added to firebase-exp
as it is not intended for public usage. We don't expose it in firebase
today.
Thanks for the info. Reverted the changes to installations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just need some updates in the package.json file
Also adding a missing param doc.