Skip to content

Adding performance to firebase-exp #3830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 24, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages-exp/firebase-exp/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@
"@firebase/app-exp": "0.0.800",
"@firebase/app-compat": "0.0.800",
"@firebase/functions-exp": "0.0.800",
"@firebase/firestore": "1.17.0"
"@firebase/firestore": "1.17.0",
"@firebase/performance-exp": "0.0.800"
},
"devDependencies": {
"rollup": "2.28.1",
Expand All @@ -60,6 +61,7 @@
"app",
"functions",
"firestore",
"firestore/lite"
"firestore/lite",
"performance"
]
}
17 changes: 17 additions & 0 deletions packages-exp/firebase-exp/performance/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
/**
* @license
* Copyright 2020 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
export * from '@firebase/performance-exp';
7 changes: 7 additions & 0 deletions packages-exp/firebase-exp/performance/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"name": "firebase-exp/performance",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/index.d.ts"
}
1 change: 1 addition & 0 deletions packages-exp/performance-exp/src/resources/trace.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ export class Trace implements PerformanceTrace {
private traceMeasure!: string;

/**
* @param performanceController The performance controller running.
* @param name The name of the trace.
* @param isAuto If the trace is auto-instrumented.
* @param traceMeasureName The name of the measure marker in user timing specification. This field
Expand Down