Skip to content

Make compat script work #3916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2020
Merged

Make compat script work #3916

merged 2 commits into from
Oct 9, 2020

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Oct 9, 2020

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2020

⚠️ No Changeset found

Latest commit: 454c030

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Feiyang1 Feiyang1 mentioned this pull request Oct 9, 2020
Merged
sam-gc
sam-gc approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@sam-gc sam-gc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that the I will need to update the main auth register function to also import as modularAPIs?
https://github.com/firebase/firebase-js-sdk/blob/master/packages-exp/auth-exp/src/core/auth/register.ts#L54

@Feiyang1 Feiyang1 merged commit 2f48295 into samgho/polyfill Oct 9, 2020
@Feiyang1 Feiyang1 deleted the fei-auth-polyfill branch October 9, 2020 17:26
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (f33dc14) and head commit (32a405b).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (f33dc14) and head commit (32a405b).

Test Logs

sam-gc pushed a commit that referenced this pull request Oct 9, 2020
@Feiyang1 @sam-gc
Make compat script work (#3916)
2d4f01f 
* expose modular APIs from compat

* build compat script that works with exp packages
sam-gc added a commit that referenced this pull request Oct 9, 2020
@sam-gc @Feiyang1
Update auth compat polyfill to use composition instead of inheritance (…
88e1f88 
…#3900)

* Auth compat index

* Go back to old way

* Switch to compositional compat layer instead of inheritance-based

* Formatting

* Comment formatting

* Fix linter issues

* PR feedback

* Pull auth from service instead of instantiating directly

* Make compat script work (#3916)

* expose modular APIs from compat

* build compat script that works with exp packages

* Fix linter issues

Co-authored-by: Feiyang <[email protected]>
@firebase firebase locked and limited conversation to collaborators Nov 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam-gc sam-gc sam-gc approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Feiyang1 @google-oss-bot @sam-gc