Skip to content

Add database-exp #4197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 21, 2021
Merged

Add database-exp #4197

merged 10 commits into from
Jan 21, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

This adds getDatabase and initializeDatabase to firebase-exp.

@changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2020 •
edited
Loading

⚠️ No Changeset found

Latest commit: 03aee06

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Feiyang1
Feiyang1 reviewed Dec 11, 2020
View reviewed changes
@schmidt-sebastian
Copy link
Contributor Author

@Feiyang1 Do you have time to look at this again? We would like to get this merged before the next EAP release.

Feiyang1
Feiyang1 reviewed Jan 16, 2021
View reviewed changes
@Feiyang1
Copy link
Member

#4317 should fix the CI failure and includes a minor build fix.

@Feiyang1
Minor build fixes (#4317)
03aee06 
* always build app exp because storage and database will need it

* transform imports from @firebase/app-exp to @firebase/app
@firebase firebase deleted a comment from google-oss-bot Jan 21, 2021
@Feiyang1 Feiyang1 merged commit fb90580 into master Jan 21, 2021
@firebase firebase locked and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@jsdt jsdt Awaiting requested review from jsdt

@hsubox76 hsubox76 Awaiting requested review from hsubox76

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees

@hsubox76 hsubox76

@schmidt-sebastian schmidt-sebastian

Labels
api: database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @Feiyang1 @hsubox76