Minor build fixes #4317
Merged
Minor build fixes #4317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feiyang1
requested review from
hiranya911,
hsubox76,
jsdt and
schmidt-sebastian
as code owners
|
Merged
schmidt-sebastian
approved these changes
Jan 21, 2021
Size Analysis Report |
Feiyang1
added a commit
that referenced
this pull request
Jan 21, 2021
* Add database-exp * Lint * Fix yarn build * Use instance identifier * lint * Update packages/database/package.json Co-authored-by: Feiyang <[email protected]> * Review * Remove initializeDatabase * Minor build fixes (#4317) * always build app exp because storage and database will need it * transform imports from @firebase/app-exp to @firebase/app Co-authored-by: Feiyang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will create a separate PR directly into master to add RTDB to the exp release process.