Skip to content

Minor build fixes #4317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Minor build fixes #4317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
389e18c
always build app exp because storage and database will need it
Feiyang1 Jan 21, 2021
4d15ce9
transform imports from @firebase/app-exp to @firebase/app
Feiyang1 Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-changed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@ jobs:
cp config/ci.config.json config/project.json
yarn
- name: build
run: yarn build:changed core
run: yarn build:changed core --buildAppExp
- name: Run tests on changed packages
run: xvfb-run yarn test:changed core
7 changes: 5 additions & 2 deletions packages/database/rollup.config.exp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import json from '@rollup/plugin-json';
import typescriptPlugin from 'rollup-plugin-typescript2';
import typescript from 'typescript';
import path from 'path';
import { importPathTransformer } from '../../scripts/exp/ts-transform-import-path';

import pkg from './exp/package.json';

Expand All @@ -31,7 +32,8 @@ const deps = Object.keys(
*/
const es5BuildPlugins = [
typescriptPlugin({
typescript
typescript,
transformers: [importPathTransformer]
}),
json()
];
Expand Down Expand Up @@ -71,7 +73,8 @@ const es2017BuildPlugins = [
compilerOptions: {
target: 'es2017'
}
}
},
transformers: [importPathTransformer]
}),
json({ preferConst: true })
];
Expand Down