Skip to content

Fix analytics-exp type exports #4327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2021
Merged

Fix analytics-exp type exports #4327

merged 1 commit into from
Jan 22, 2021

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Jan 22, 2021 •
edited
Loading

Separate type import and export statements. Transformer is causing some trouble with export type.

@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 22223ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 22, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (86ea407) and head commit (735ab9e).

Feiyang1
Feiyang1 reviewed Jan 22, 2021
View reviewed changes
@hsubox76 hsubox76 changed the title Exp release fixes Fix analytics-exp type exports Jan 22, 2021
@hsubox76 hsubox76 merged commit 4bb72b6 into master Jan 22, 2021
@hsubox76 hsubox76 deleted the ch-expfix2 branch January 22, 2021 19:48
@firebase firebase locked and limited conversation to collaborators Feb 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @google-oss-bot @Feiyang1