Tree-Shake Path #4477

schmidt-sebastian · 2021-02-16T20:16:18Z

No description provided.

changeset-bot · 2021-02-16T20:16:21Z

⚠️ No Changeset found

Latest commit: 95dcf15

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2021-02-16T21:55:16Z

Binary Size Report

Affected SDKs

`@firebase/app`

Type	Base (`8c92c1a`)	Head (`106b335`)	Diff
browser	11.2 kB	10.8 kB	-353 B (-3.2%)
esm2017	9.58 kB	9.57 kB	-12 B (-0.1%)
lite	9.25 kB	8.88 kB	-372 B (-4.0%)
lite-esm2017	7.88 kB	7.87 kB	-12 B (-0.2%)
main	10.9 kB	10.6 kB	-360 B (-3.3%)
module	11.2 kB	10.8 kB	-353 B (-3.2%)
react-native	10.6 kB	10.3 kB	-360 B (-3.4%)

@firebase/database

Type Base (8c92c1a) Head (106b335) Diff

browser 277 kB 278 kB +478 B (+0.2%)

esm2017 245 kB 246 kB +839 B (+0.3%)

main 280 kB 280 kB +478 B (+0.2%)

module 277 kB 278 kB +478 B (+0.2%)
@firebase/database-exp

Type Base (8c92c1a) Head (106b335) Diff

browser 278 kB 278 kB +478 B (+0.2%)

esm2017 243 kB 243 kB +839 B (+0.3%)

main 280 kB 280 kB +478 B (+0.2%)

module 278 kB 278 kB +478 B (+0.2%)

`firebase`

Type	Base (`8c92c1a`)	Head (`106b335`)	Diff
firebase-app.js	20.2 kB	19.9 kB	-276 B (-1.4%)
firebase-database.js	193 kB	191 kB	-1.75 kB (-0.9%)
firebase-performance-standalone.es2017.js	71.9 kB	71.9 kB	-10 B (-0.0%)
firebase-performance-standalone.js	48.3 kB	48.0 kB	-271 B (-0.6%)
firebase.js	854 kB	852 kB	-2.03 kB (-0.2%)

Test Logs

Base (8c92c1ac): https://github.com/firebase/firebase-js-sdk/actions/runs/572695621
Head (106b3352): https://github.com/firebase/firebase-js-sdk/actions/runs/576237905

hsubox76 · 2021-02-17T19:20:06Z

packages/database/src/core/util/validation.ts

@@ -215,11 +223,11 @@ export const validateFirebaseMergePaths = function (
  // Check that update keys are not descendants of each other.
  // We rely on the property that sorting guarantees that ancestors come
  // right before descendants.
-  mergePaths.sort(Path.comparePaths);
+  mergePaths.sort((l, r) => pathCompare(l, r));


does pathCompare not work by itself?

It should, but it might be a bit of an anti-pattern, as it might introduce some future breakages if the callsite ends up passing arguments that pathCompare does not support (e.g. a "position" argument that is passed pathCompare, which might expect an optional string description instead).

I did update this location though since it matches the original implementation.

google-oss-bot · 2021-02-17T21:58:10Z

Size Analysis Report

Affected Products

`@firebase/app-exp`

`_addComponent`

Dependency Table

Type	Base (`8c92c1a`)	Head (`106b335`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`_addOrOverwriteComponent`

Dependency Table

Type	Base (`8c92c1a`)	Head (`106b335`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`_clearComponents`

Dependency Table

Type	Base (`8c92c1a`)	Head (`106b335`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`_getProvider`

Dependency Table

Type	Base (`8c92c1a`)	Head (`106b335`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`_registerComponent`

Dependency Table

Type	Base (`8c92c1a`)	Head (`106b335`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`_removeServiceInstance`

Dependency Table

Type	Base (`8c92c1a`)	Head (`106b335`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`deleteApp`

Dependency Table

Type	Base (`8c92c1a`)	Head (`106b335`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`getApp`

Dependency Table

Type	Base (`8c92c1a`)	Head (`106b335`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`getApps`

Dependency Table

Type	Base (`8c92c1a`)	Head (`106b335`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

initializeApp
Size Table
Type Base (8c92c1a) Head (106b335) Diff
size
3.96 kB
4.08 kB
+115 B (+2.9%)
size-with-ext-deps
9.24 kB
9.36 kB
+115 B (+1.2%)
Dependency Table
Type Base (8c92c1a) Head (106b335) Diff
classes
FirebaseAppImpl PlatformLoggerService
FirebaseAppImpl PlatformLoggerServiceImpl
+ PlatformLoggerServiceImpl - PlatformLoggerService

`onLog`

Dependency Table

Type	Base (`8c92c1a`)	Head (`106b335`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`registerVersion`

Dependency Table

Type	Base (`8c92c1a`)	Head (`106b335`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`setLogLevel`

Dependency Table

Type	Base (`8c92c1a`)	Head (`106b335`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`SDK_VERSION`

Dependency Table

Type	Base (`8c92c1a`)	Head (`106b335`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`_DEFAULT_ENTRY_NAME`

Dependency Table

Type	Base (`8c92c1a`)	Head (`106b335`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`_apps`

Dependency Table

Type	Base (`8c92c1a`)	Head (`106b335`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`_components`

Dependency Table

Type	Base (`8c92c1a`)	Head (`106b335`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

@firebase/auth-exp
- ActionCodeURL
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  29.0 kB
  29.0 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.7 kB
  39.7 kB
  -5 B (-0.0%)
- AuthCredential
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.2 kB
  28.2 kB
  -5 B (-0.0%)
  size-with-ext-deps
  38.9 kB
  38.9 kB
  -5 B (-0.0%)
- EmailAuthCredential
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  29.9 kB
  29.9 kB
  -5 B (-0.0%)
  size-with-ext-deps
  40.7 kB
  40.7 kB
  -5 B (-0.0%)
- EmailAuthProvider
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  31.3 kB
  31.3 kB
  -5 B (-0.0%)
  size-with-ext-deps
  42.0 kB
  42.0 kB
  -5 B (-0.0%)
- FacebookAuthProvider
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  31.8 kB
  31.8 kB
  -5 B (-0.0%)
  size-with-ext-deps
  42.5 kB
  42.5 kB
  -5 B (-0.0%)
- GithubAuthProvider
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  31.8 kB
  31.8 kB
  -5 B (-0.0%)
  size-with-ext-deps
  42.5 kB
  42.5 kB
  -5 B (-0.0%)
- GoogleAuthProvider
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  31.8 kB
  31.8 kB
  -5 B (-0.0%)
  size-with-ext-deps
  42.5 kB
  42.5 kB
  -5 B (-0.0%)
- OAuthCredential
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  30.0 kB
  30.0 kB
  -5 B (-0.0%)
  size-with-ext-deps
  40.7 kB
  40.7 kB
  -5 B (-0.0%)
- OAuthProvider
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  31.2 kB
  31.2 kB
  -5 B (-0.0%)
  size-with-ext-deps
  41.9 kB
  41.9 kB
  -5 B (-0.0%)
- PhoneAuthCredential
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  30.0 kB
  30.0 kB
  -5 B (-0.0%)
  size-with-ext-deps
  40.7 kB
  40.7 kB
  -5 B (-0.0%)
- PhoneAuthProvider
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  31.6 kB
  31.6 kB
  -5 B (-0.0%)
  size-with-ext-deps
  42.3 kB
  42.3 kB
  -5 B (-0.0%)
- PhoneMultiFactorGenerator
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.9 kB
  28.8 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.6 kB
  39.6 kB
  -5 B (-0.0%)
- RecaptchaVerifier
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  34.2 kB
  34.3 kB
  +84 B (+0.2%)
  size-with-ext-deps
  44.9 kB
  45.0 kB
  +85 B (+0.2%)
- TwitterAuthProvider
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  31.8 kB
  31.8 kB
  -5 B (-0.0%)
  size-with-ext-deps
  42.5 kB
  42.5 kB
  -5 B (-0.0%)
- applyActionCode
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.1 kB
  28.0 kB
  -5 B (-0.0%)
  size-with-ext-deps
  38.8 kB
  38.8 kB
  -5 B (-0.0%)
- checkActionCode
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  29.0 kB
  29.0 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.7 kB
  39.7 kB
  -5 B (-0.0%)
- confirmPasswordReset
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.1 kB
  28.1 kB
  -5 B (-0.0%)
  size-with-ext-deps
  38.8 kB
  38.8 kB
  -5 B (-0.0%)
- createUserWithEmailAndPassword
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  29.0 kB
  29.0 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.7 kB
  39.7 kB
  -5 B (-0.0%)
- deleteUser
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.0 kB
  28.0 kB
  -5 B (-0.0%)
  size-with-ext-deps
  38.7 kB
  38.7 kB
  -5 B (-0.0%)
- fetchSignInMethodsForEmail
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.3 kB
  28.3 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.0 kB
  39.0 kB
  -5 B (-0.0%)
- getAdditionalUserInfo
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  29.3 kB
  29.3 kB
  -5 B (-0.0%)
  size-with-ext-deps
  40.0 kB
  40.0 kB
  -5 B (-0.0%)
- getAuth
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  55.7 kB
  55.6 kB
  -5 B (-0.0%)
  size-with-ext-deps
  66.6 kB
  66.6 kB
  -5 B (-0.0%)
- getIdToken
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.0 kB
  28.0 kB
  -5 B (-0.0%)
  size-with-ext-deps
  38.7 kB
  38.7 kB
  -5 B (-0.0%)
- getIdTokenResult
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  27.9 kB
  27.9 kB
  -5 B (-0.0%)
  size-with-ext-deps
  38.6 kB
  38.6 kB
  -5 B (-0.0%)
- getMultiFactorResolver
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  30.7 kB
  30.7 kB
  -5 B (-0.0%)
  size-with-ext-deps
  41.4 kB
  41.4 kB
  -5 B (-0.0%)
- getRedirectResult
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  33.6 kB
  33.6 kB
  -5 B (-0.0%)
  size-with-ext-deps
  44.3 kB
  44.3 kB
  -5 B (-0.0%)
- initializeAuth
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.4 kB
  28.4 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.1 kB
  39.1 kB
  -5 B (-0.0%)
- isSignInWithEmailLink
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  29.1 kB
  29.1 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.8 kB
  39.8 kB
  -5 B (-0.0%)
- linkWithCredential
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  29.0 kB
  29.0 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.7 kB
  39.7 kB
  -5 B (-0.0%)
- linkWithPhoneNumber
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  32.5 kB
  32.5 kB
  -5 B (-0.0%)
  size-with-ext-deps
  43.2 kB
  43.2 kB
  -5 B (-0.0%)
- linkWithPopup
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  36.9 kB
  36.9 kB
  -5 B (-0.0%)
  size-with-ext-deps
  47.6 kB
  47.6 kB
  -5 B (-0.0%)
- linkWithRedirect
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  31.9 kB
  31.9 kB
  -5 B (-0.0%)
  size-with-ext-deps
  42.6 kB
  42.6 kB
  -5 B (-0.0%)
- multiFactor
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  30.0 kB
  30.0 kB
  -5 B (-0.0%)
  size-with-ext-deps
  40.8 kB
  40.7 kB
  -5 B (-0.0%)
- onAuthStateChanged
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.0 kB
  28.0 kB
  -5 B (-0.0%)
  size-with-ext-deps
  38.7 kB
  38.7 kB
  -5 B (-0.0%)
- onIdTokenChanged
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.0 kB
  28.0 kB
  -5 B (-0.0%)
  size-with-ext-deps
  38.7 kB
  38.7 kB
  -5 B (-0.0%)
- parseActionCodeURL
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  29.0 kB
  29.0 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.7 kB
  39.7 kB
  -5 B (-0.0%)
- reauthenticateWithCredential
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  29.6 kB
  29.6 kB
  -5 B (-0.0%)
  size-with-ext-deps
  40.3 kB
  40.3 kB
  -5 B (-0.0%)
- reauthenticateWithPhoneNumber
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  33.0 kB
  33.0 kB
  -5 B (-0.0%)
  size-with-ext-deps
  43.8 kB
  43.8 kB
  -5 B (-0.0%)
- reauthenticateWithPopup
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  36.9 kB
  36.9 kB
  -5 B (-0.0%)
  size-with-ext-deps
  47.7 kB
  47.6 kB
  -5 B (-0.0%)
- reauthenticateWithRedirect
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  31.7 kB
  31.7 kB
  -5 B (-0.0%)
  size-with-ext-deps
  42.4 kB
  42.4 kB
  -5 B (-0.0%)
- reload
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  27.9 kB
  27.9 kB
  -5 B (-0.0%)
  size-with-ext-deps
  38.6 kB
  38.6 kB
  -5 B (-0.0%)
- sendEmailVerification
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.9 kB
  28.9 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.6 kB
  39.6 kB
  -5 B (-0.0%)
- sendPasswordResetEmail
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.8 kB
  28.8 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.5 kB
  39.5 kB
  -5 B (-0.0%)
- sendSignInLinkToEmail
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.8 kB
  28.8 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.6 kB
  39.5 kB
  -5 B (-0.0%)
- setPersistence
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.0 kB
  28.0 kB
  -5 B (-0.0%)
  size-with-ext-deps
  38.7 kB
  38.7 kB
  -5 B (-0.0%)
- signInAnonymously
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  29.1 kB
  29.1 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.8 kB
  39.8 kB
  -5 B (-0.0%)
- signInWithCredential
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  29.4 kB
  29.3 kB
  -5 B (-0.0%)
  size-with-ext-deps
  40.1 kB
  40.1 kB
  -5 B (-0.0%)
- signInWithCustomToken
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  29.0 kB
  29.0 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.7 kB
  39.7 kB
  -5 B (-0.0%)
- signInWithEmailAndPassword
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  32.8 kB
  32.8 kB
  -5 B (-0.0%)
  size-with-ext-deps
  43.5 kB
  43.5 kB
  -5 B (-0.0%)
- signInWithEmailLink
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  33.0 kB
  33.0 kB
  -5 B (-0.0%)
  size-with-ext-deps
  43.7 kB
  43.7 kB
  -5 B (-0.0%)
- signInWithPhoneNumber
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  32.8 kB
  32.8 kB
  -5 B (-0.0%)
  size-with-ext-deps
  43.5 kB
  43.5 kB
  -5 B (-0.0%)
- signInWithPopup
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  36.9 kB
  36.9 kB
  -5 B (-0.0%)
  size-with-ext-deps
  47.6 kB
  47.6 kB
  -5 B (-0.0%)
- signInWithRedirect
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  31.4 kB
  31.4 kB
  -5 B (-0.0%)
  size-with-ext-deps
  42.1 kB
  42.1 kB
  -5 B (-0.0%)
- signOut
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.0 kB
  28.0 kB
  -5 B (-0.0%)
  size-with-ext-deps
  38.7 kB
  38.7 kB
  -5 B (-0.0%)
- unlink
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.5 kB
  28.5 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.2 kB
  39.2 kB
  -5 B (-0.0%)
- updateCurrentUser
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.0 kB
  28.0 kB
  -5 B (-0.0%)
  size-with-ext-deps
  38.7 kB
  38.7 kB
  -5 B (-0.0%)
- updateEmail
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.3 kB
  28.2 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.0 kB
  39.0 kB
  -5 B (-0.0%)
- updatePassword
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.3 kB
  28.3 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.0 kB
  39.0 kB
  -5 B (-0.0%)
- updatePhoneNumber
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.7 kB
  28.7 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.4 kB
  39.4 kB
  -5 B (-0.0%)
- updateProfile
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.4 kB
  28.4 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.2 kB
  39.2 kB
  -5 B (-0.0%)
- useAuthEmulator
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  29.0 kB
  29.2 kB
  +196 B (+0.7%)
  size-with-ext-deps
  39.7 kB
  39.9 kB
  +196 B (+0.5%)
- useDeviceLanguage
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.0 kB
  28.0 kB
  -5 B (-0.0%)
  size-with-ext-deps
  38.7 kB
  38.7 kB
  -5 B (-0.0%)
- verifyBeforeUpdateEmail
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.9 kB
  28.9 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.6 kB
  39.6 kB
  -5 B (-0.0%)
- verifyPasswordResetCode
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  29.1 kB
  29.1 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.8 kB
  39.8 kB
  -5 B (-0.0%)
- browserLocalPersistence
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  30.9 kB
  30.9 kB
  -5 B (-0.0%)
  size-with-ext-deps
  41.7 kB
  41.7 kB
  -5 B (-0.0%)
- browserPopupRedirectResolver
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  45.3 kB
  45.3 kB
  -5 B (-0.0%)
  size-with-ext-deps
  56.2 kB
  56.2 kB
  -5 B (-0.0%)
- browserSessionPersistence
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  28.6 kB
  28.6 kB
  -5 B (-0.0%)
  size-with-ext-deps
  39.3 kB
  39.3 kB
  -5 B (-0.0%)
- debugErrorMap
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  38.8 kB
  38.8 kB
  -5 B (-0.0%)
  size-with-ext-deps
  49.5 kB
  49.5 kB
  -5 B (-0.0%)
- inMemoryPersistence
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  27.9 kB
  27.9 kB
  -5 B (-0.0%)
  size-with-ext-deps
  38.7 kB
  38.6 kB
  -5 B (-0.0%)
- indexedDBLocalPersistence
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  35.3 kB
  35.3 kB
  -5 B (-0.0%)
  size-with-ext-deps
  46.0 kB
  46.0 kB
  -5 B (-0.0%)
- prodErrorMap
  Size Table
  Type Base (8c92c1a) Head (106b335) Diff
  size
  27.9 kB
  27.9 kB
  -5 B (-0.0%)
  size-with-ext-deps
  38.7 kB
  38.7 kB
  -5 B (-0.0%)

Test Logs

Tree-Shake Path

dca65c4

schmidt-sebastian requested a review from jsdt as a code owner February 16, 2021 20:16

schmidt-sebastian assigned Feiyang1 and hsubox76 Feb 16, 2021

schmidt-sebastian requested review from Feiyang1 and hsubox76 February 16, 2021 20:16

schmidt-sebastian added the api: database label Feb 16, 2021

schmidt-sebastian added 3 commits February 16, 2021 17:08

Update Database.ts

5ed6bea

Update events.ts

c4b4386

Lint

419d5df

hsubox76 approved these changes Feb 17, 2021

View reviewed changes

schmidt-sebastian added 2 commits February 17, 2021 12:39

Update validation.ts

d90fb6c

Bug

0b6212d

firebase deleted a comment from google-oss-bot Feb 17, 2021

Bugs

95dcf15

schmidt-sebastian merged commit d0bae02 into master Feb 17, 2021

schmidt-sebastian deleted the mrschmidt/path branch February 17, 2021 22:22

firebase locked and limited conversation to collaborators Mar 20, 2021

Tree-Shake Path #4477

Tree-Shake Path #4477

Uh oh!

Conversation

schmidt-sebastian commented Feb 16, 2021

Uh oh!

changeset-bot bot commented Feb 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

google-oss-bot commented Feb 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Binary Size Report

Affected SDKs

@firebase/app

@firebase/database

@firebase/database-exp

firebase

Test Logs

Uh oh!

hsubox76 Feb 17, 2021

Choose a reason for hiding this comment

Uh oh!

schmidt-sebastian Feb 17, 2021

Choose a reason for hiding this comment

Uh oh!

google-oss-bot commented Feb 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report

Affected Products

@firebase/app-exp

_addComponent

_addOrOverwriteComponent

_clearComponents

_getProvider

_registerComponent

_removeServiceInstance

deleteApp

getApp

getApps

initializeApp

onLog

registerVersion

setLogLevel

SDK_VERSION

_DEFAULT_ENTRY_NAME

_apps

_components

@firebase/auth-exp

ActionCodeURL

AuthCredential

EmailAuthCredential

EmailAuthProvider

FacebookAuthProvider

GithubAuthProvider

GoogleAuthProvider

OAuthCredential

OAuthProvider

PhoneAuthCredential

PhoneAuthProvider

PhoneMultiFactorGenerator

RecaptchaVerifier

TwitterAuthProvider

applyActionCode

checkActionCode

confirmPasswordReset

createUserWithEmailAndPassword

deleteUser

fetchSignInMethodsForEmail

getAdditionalUserInfo

getAuth

getIdToken

getIdTokenResult

getMultiFactorResolver

getRedirectResult

initializeAuth

isSignInWithEmailLink

linkWithCredential

linkWithPhoneNumber

linkWithPopup

changeset-bot bot commented Feb 16, 2021 •

edited

Loading

google-oss-bot commented Feb 16, 2021 •

edited

Loading

`@firebase/app`

`@firebase/database`

`@firebase/database-exp`

`firebase`

google-oss-bot commented Feb 17, 2021 •

edited

Loading

`@firebase/app-exp`

`_addComponent`

`_addOrOverwriteComponent`

`_clearComponents`

`_getProvider`

`_registerComponent`

`_removeServiceInstance`

`deleteApp`

`getApp`

`getApps`

`initializeApp`

`onLog`

`registerVersion`

`setLogLevel`

`SDK_VERSION`

`_DEFAULT_ENTRY_NAME`

`_apps`

`_components`

`@firebase/auth-exp`

`ActionCodeURL`

`AuthCredential`

`EmailAuthCredential`

`EmailAuthProvider`

`FacebookAuthProvider`

`GithubAuthProvider`

`GoogleAuthProvider`

`OAuthCredential`

`OAuthProvider`

`PhoneAuthCredential`

`PhoneAuthProvider`

`PhoneMultiFactorGenerator`

`RecaptchaVerifier`

`TwitterAuthProvider`

`applyActionCode`

`checkActionCode`

`confirmPasswordReset`

`createUserWithEmailAndPassword`

`deleteUser`

`fetchSignInMethodsForEmail`

`getAdditionalUserInfo`

`getAuth`

`getIdToken`

`getIdTokenResult`

`getMultiFactorResolver`

`getRedirectResult`

`initializeAuth`

`isSignInWithEmailLink`

`linkWithCredential`

`linkWithPhoneNumber`

`linkWithPopup`

`linkWithRedirect`

`multiFactor`

`onAuthStateChanged`

`onIdTokenChanged`

`parseActionCodeURL`

`reauthenticateWithCredential`

`reauthenticateWithPhoneNumber`

`reauthenticateWithPopup`

`reauthenticateWithRedirect`

`reload`

`sendEmailVerification`

`sendPasswordResetEmail`

`sendSignInLinkToEmail`

`setPersistence`

`signInAnonymously`

`signInWithCredential`

`signInWithCustomToken`

`signInWithEmailAndPassword`

`signInWithEmailLink`

`signInWithPhoneNumber`

`signInWithPopup`

`signInWithRedirect`

`signOut`