Skip to content

Implement functions and storage compat interop #4639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 1, 2021
Merged

Implement functions and storage compat interop #4639

merged 14 commits into from
Apr 1, 2021

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Mar 15, 2021 •
edited
Loading

Modify functions and storage exp methods to accept compat instances.

@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0006320

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 15, 2021 •
edited
Loading

Size Analysis Report

Affected Products

Diffs between base commit (9a9f647) and head commit (4da4a17) are too large (477,135 characters) to display.

Please check below links to see details from the original test log.

@hsubox76 hsubox76 changed the title WIP test compat typing Implement functions compat interop Mar 19, 2021
Feiyang1
Feiyang1 reviewed Mar 19, 2021
View reviewed changes
Feiyang1
Feiyang1 reviewed Mar 19, 2021
View reviewed changes
hsubox76
hsubox76 commented Mar 19, 2021
View reviewed changes
Feiyang1
Feiyang1 reviewed Mar 19, 2021
View reviewed changes
@hsubox76
Copy link
Contributor Author

Fixed merge conflicts and updated deprecated TS methods.

@hsubox76 hsubox76 changed the title Implement functions compat interop Implement functions and storage compat interop Mar 31, 2021
Feiyang1
Feiyang1 suggested changes Mar 31, 2021
View reviewed changes
Copy link
Member

@Feiyang1 Feiyang1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to convert StorageReference related functions too.

packages/storage/exp/api.ts Outdated
Comment on lines 259 to 266
if (serviceOrRef instanceof Reference) {
return refInternal(serviceOrRef as Reference, pathOrUrl);
} else {
return refInternal(
getModularInstance(serviceOrRef) as StorageServiceInternal,
pathOrUrl
);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to check whether it's a StorageService or Reference. Both of them can be a compat instance, we can just call getModularInstance() and pass the result to refInternal().

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@hsubox76 hsubox76 merged commit b374636 into master Apr 1, 2021
@hsubox76 hsubox76 deleted the ch-compat-test branch April 1, 2021 00:33
@firebase firebase locked and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @google-oss-bot @Feiyang1