[Auth] Restrict the ':' character in API key #4706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sam-gc
force-pushed
the
samgho/key-restriction
branch
from
c0f2a47 to
c51e94a
Compare
yuchenshi
approved these changes
Apr 1, 2021
sam-gc
force-pushed
the
samgho/key-restriction
branch
from
c51e94a to
a836d6f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prevent potential collisions with app name in the persistence layer (as
:is used as the separator). In practice this will only ever apply when using fake API key / app against the emulator as no actual API key has:.