Skip to content

[Auth] Restrict the ':' character in API key #4706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 2, 2021
Merged

[Auth] Restrict the ':' character in API key #4706

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39cf683
Restrict the ':' character in API key
sam-gc Apr 1, 2021
1ecea9b
Formatting
sam-gc Apr 1, 2021
b35e476
Add domain test as well
sam-gc Apr 1, 2021
a836d6f
Formatting
sam-gc Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages-exp/auth-exp/src/core/auth/register.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,15 @@ export function registerAuth(clientPlatform: ClientPlatform): void {
const app = container.getProvider('app-exp').getImmediate()!;
const { apiKey, authDomain } = app.options;
return (app => {
_assert(apiKey, AuthErrorCode.INVALID_API_KEY, { appName: app.name });
_assert(
apiKey && !apiKey.includes(':'),
AuthErrorCode.INVALID_API_KEY,
{ appName: app.name }
);
// Auth domain is optional if IdP sign in isn't being used
_assert(!authDomain?.includes(':'), AuthErrorCode.ARGUMENT_ERROR, {
appName: app.name
});
const config: ConfigInternal = {
apiKey,
authDomain,
Expand Down