Skip to content

Update database type names #5136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2021
Merged

Update database type names #5136

merged 3 commits into from
Jul 23, 2021

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Jul 9, 2021

go/js-v9-types-naming

@Feiyang1 Feiyang1 added the v9 label Jul 9, 2021
@Feiyang1 Feiyang1 added this to the v9 GA milestone Jul 9, 2021
@changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8884984

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2021 •
edited
Loading

Changeset File Check ⚠️

  • Changeset formatting error in following file: 
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.7" vs "file:../../packages-exp/firebase-exp"
Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.7" vs "file:../../packages-exp/firebase-exp"
Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.7" vs "file:../../packages-exp/firebase-exp"
Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

@github-actions github-actions bot added the doc-changes PRs that affect docs label Jul 10, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 10, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/database

    Type Base (d56ab5c) Head (c334d53) Diff
    browser 296 kB 296 kB -60 B (-0.0%)
    esm2017 265 kB 265 kB -12 B (-0.0%)
    main 299 kB 299 kB -60 B (-0.0%)
    module 296 kB 296 kB -60 B (-0.0%)

  • @firebase/database-exp

    Type Base (d56ab5c) Head (c334d53) Diff
    browser 246 kB 246 kB -24 B (-0.0%)
    main 278 kB 278 kB -112 B (-0.0%)
    module 246 kB 246 kB -24 B (-0.0%)

  • @firebase/firestore/memory

    Type Base (d56ab5c) Head (c334d53) Diff
    browser 217 kB 217 kB -96 B (-0.0%)
    module 217 kB 217 kB -96 B (-0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 10, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (d56ab5c) and head commit (c334d53).

@schmidt-sebastian schmidt-sebastian removed their assignment Jul 13, 2021
@Feiyang1 Feiyang1 changed the title update database type names [WIP] update database type names Jul 19, 2021
@Feiyang1 Feiyang1 changed the title [WIP] update database type names Update database type names Jul 22, 2021
egilmorez
egilmorez approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here, doc-wise, thanks!

@Feiyang1 Feiyang1 assigned hsubox76 and unassigned egilmorez Jul 23, 2021
@Feiyang1 Feiyang1 merged commit 58b7266 into master Jul 23, 2021
@Feiyang1 Feiyang1 deleted the fei-typename-database branch July 23, 2021 21:04
@Feiyang1 Feiyang1 mentioned this pull request Jul 27, 2021
Closed
@firebase firebase locked and limited conversation to collaborators Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@egilmorez egilmorez egilmorez approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@jsdt jsdt Awaiting requested review from jsdt

Assignees

@hsubox76 hsubox76

Labels
doc-changes PRs that affect docs v9
Projects
None yet
Milestone
v9 GA
Development

Successfully merging this pull request may close these issues.
5 participants
@Feiyang1 @google-oss-bot @egilmorez @hsubox76 @schmidt-sebastian