Skip to content

Notify JSCore chat when smoke tests complete #5557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Oct 11, 2021
Merged

Notify JSCore chat when smoke tests complete #5557

merged 21 commits into from
Oct 11, 2021

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Sep 28, 2021

Send a notification to JSCore chat when a test has succeeded or failed, with a version number and a link to the workflow run.

Also fixed a mistake, it should be installing firebase@next to get the staging version.

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2021

⚠️ No Changeset found

Latest commit: 99c4ea4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla google-cla bot added the cla: yes label Sep 28, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 28, 2021

Binary Size Report

Affected SDKs

  • @firebase/storage

    Type Base (e456d00) Head (cfc87fe) Diff
    main 53.5 kB 53.6 kB +75 B (+0.1%)
  • firebase

    Type Base (e456d00) Head (cfc87fe) Diff
    firebase-storage.js 140 kB 140 kB +128 B (+0.1%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 28, 2021

Size Analysis Report

Affected Products

No changes between base commit (e456d00) and head commit (cfc87fe).

@@ -1,6 +1,6 @@
name: E2E Smoke Tests

on: workflow_dispatch
on: [push, workflow_dispatch]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we trigger it on every canary and staging release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already triggered on staging, adding a comment. Canary may be added later, we would need to trigger a workflow from the canary workflow.

@hsubox76 hsubox76 changed the title WIP: Notify JSCore chat when smoke tests complete Notify JSCore chat when smoke tests complete Sep 29, 2021
@Feiyang1 Feiyang1 assigned hsubox76 and unassigned Feiyang1 Oct 6, 2021
@hsubox76 hsubox76 assigned Feiyang1 and unassigned hsubox76 Oct 6, 2021
@Feiyang1 Feiyang1 assigned hsubox76 and unassigned Feiyang1 Oct 11, 2021
@hsubox76 hsubox76 merged commit fc1d364 into master Oct 11, 2021
@hsubox76 hsubox76 deleted the ch-e2e-notify branch October 11, 2021 17:13
@firebase firebase locked and limited conversation to collaborators Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants