-
Notifications
You must be signed in to change notification settings - Fork 948
Notify JSCore chat when smoke tests complete #5557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Binary Size ReportAffected SDKs
Test Logs
|
Size Analysis Report |
.github/workflows/e2e-test.yml
Outdated
@@ -1,6 +1,6 @@ | |||
name: E2E Smoke Tests | |||
|
|||
on: workflow_dispatch | |||
on: [push, workflow_dispatch] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we trigger it on every canary and staging release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already triggered on staging, adding a comment. Canary may be added later, we would need to trigger a workflow from the canary workflow.
efed631
to
4900890
Compare
Send a notification to JSCore chat when a test has succeeded or failed, with a version number and a link to the workflow run.
Also fixed a mistake, it should be installing
firebase@next
to get the staging version.