Move getPushSubscription method to ControllerInterface. #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauntface
reviewed
Mar 22, 2018
| email: string, | ||
| password: string | ||
| ): Promise<any>; | ||
| createUserAndRetrieveDataWithEmailAndPassword( |
There was a problem hiding this comment.
@jshcrowthe this prettier auto stuff really drags on PRs :(
There was a problem hiding this comment.
Agreed, @schmidt-sebastian and I have both proposed solutions to handle this (#585, #580). Both scope the change down to only your package so other components changes shouldn't be included as much.
gauntface
approved these changes
Mar 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both SWController and WindowController need to implement getPushSubscription method to use in the getToken flow. For SwController, the parameters of the method is a bit redundant: we pass a swRegistration in the method, even though SWController has internal access to it. @gauntface