Refactor Prettier Implementation (Post Commit Style) #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally we scope them to only the changed files to prevent out of scope changes
|
Can we work around the limitations if we also run |
| * Checks if the files in question have associated diffs | ||
| */ | ||
| async function hasDiff(files) { | ||
| let { stdout } = await exec(`git diff ${files.join(' ')}`, { cwd: root }); |
There was a problem hiding this comment.
You can pass --quiet and then check the exit code: https://git-scm.com/docs/git-diff.
You can then likely skip passing in the filenames, which will prevent me from breaking this in the future by maliciously using filenames that contain single quotes.
|
Ping :) |
|
I'm not super excited about doing this on commit. Last I talked to Josh I think he was going to look into making the existing pre-push hook only run prettier on changed files which should solve the original performance issues (and spurious prettier edits on files you didn't touch). |
|
I'ma close this for now. Will revisit in the future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #580 per a conversation with @schmidt-sebastian. This changes the behavior of the prettier implementation to do the following:
.ts/.js/.json)Limitations w/ this approach: