Skip to content

Use collectionGroupReadTimeIndex for multi-tab synchronization #6073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 18, 2022
Merged

Use collectionGroupReadTimeIndex for multi-tab synchronization #6073

merged 3 commits into from
Mar 18, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Mar 16, 2022 •
edited
Loading

This drops one index created by #5988 and changes the multi-tab synchronization to use the collection group read time index. This works pretty well for normal query execution, but needs some adjusting to bundle loading as we don't know the collection groups of the bundles. As such, this PR adds functionality to the bundle loader to persist the names of the affected collection groups in LocalStoragel

@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: aa70d16

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 16, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (69aa7b0)Merge (fe17304)Diff
    browser251 kB251 kB+14 B (+0.0%)
    esm5312 kB312 kB+13 B (+0.0%)
    main502 kB502 kB-474 B (-0.1%)
    module251 kB251 kB+14 B (+0.0%)
    react-native251 kB251 kB+14 B (+0.0%)

  • bundle

    TypeBase (69aa7b0)Merge (fe17304)Diff
    firestore (Persistence)262 kB261 kB-174 B (-0.1%)
    firestore (Query Cursors)202 kB202 kB+242 B (+0.1%)
    firestore (Query)203 kB203 kB+242 B (+0.1%)
    firestore (Read data once)192 kB192 kB+242 B (+0.1%)
    firestore (Realtime updates)194 kB194 kB+242 B (+0.1%)
    firestore (Transaction)176 kB176 kB+5 B (+0.0%)
    firestore (Write data)176 kB176 kB+5 B (+0.0%)

  • firebase

    TypeBase (69aa7b0)Merge (fe17304)Diff
    firebase-compat.js778 kB778 kB+26 B (+0.0%)
    firebase-firestore-compat.js303 kB303 kB+26 B (+0.0%)
    firebase-firestore.js822 kB821 kB-1.03 kB (-0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/DiOtmhBq8h.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 16, 2022 •
edited
Loading

Size Analysis Report 1

This report is too large (343,385 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xrzjYrA3HI.html

@schmidt-sebastian schmidt-sebastian changed the title Remove readTimeIndex Use collectionGroupReadTimeIndex for multi-tab synchronization Mar 17, 2022
@schmidt-sebastian schmidt-sebastian marked this pull request as ready for review March 17, 2022 21:00
Base automatically changed from mrschmidt/rdc to master March 18, 2022 15:49
wu-hui
wu-hui approved these changes Mar 18, 2022
View reviewed changes
packages/firestore/test/unit/local/remote_document_cache.test.ts Outdated
});

it('can get changes', async () => {
it('cen get next documents from collection group with limit', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can, and below

@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Mar 18, 2022
@schmidt-sebastian schmidt-sebastian merged commit 14ccbad into master Mar 18, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/usecgindex branch March 18, 2022 21:01
@firebase firebase locked and limited conversation to collaborators Apr 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @wu-hui