Implement password validation and update internal caching to store schema version #7424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add password policy endpoint in auth to allow fetching the password policy for the project/tenant
…check into validatePassword
|
ch5zzy
commented
Jul 6, 2023
| isValid: validFlag, | ||
| ...(policy.customStrengthOptions.minPasswordLength && { | ||
| meetsMinPasswordLength: minLengthFlag | ||
| }), |
There was a problem hiding this comment.
This allows meetsMinPasswordLength to only be defined in the status if minPasswordLength is defined in the policy. Same with the other properties, since we only want them to be defined if they are required by the policy.
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
ch5zzy
requested review from
lisajian,
prameshj,
renkelvin,
sam-gc and
a team
as code owners
renkelvin
reviewed
Jul 7, 2023
ch5zzy
requested review from
egilmorez,
markarndt and
kevinthecheung
as code owners
github-actions
bot
requested review from
dwyfrequency and
hsubox76
as code owners
Xiaoshouzi-gh
requested changes
Jul 7, 2023
| } | ||
|
|
||
| // Check character options. | ||
| let char; |
|
|
||
| auth = await testAuth(); | ||
| auth.tenantId = TEST_TENANT_ID_REQUIRE_ALL; | ||
| const status = await auth.validatePassword('P4ssword'); |
There was a problem hiding this comment.
can we also add 2 lines to test 'P4sswo@d'?
|
Creating a new PR for these changes since it has been split into multiple PRs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement password validation (validatePassword endpoint) and update internal caching to store schema version so
UNSUPPORTED_PASSWORD_POLICY_SCHEMA_VERSIONcan be propagated when validatePassword is called