Implement validatePassword endpoint and fix PasswordPolicy type to match API proposal #7456

ch5zzy · 2023-07-13T18:26:22Z

Implement the validatePassword function in both Auth and PasswordPolicyImpl. Also, fix PasswordPolicy.allowedNonAlphanumericCharacters to be of type string instead of string[] to match the API proposal.

See this PR for previous discussion on this implementation.

…yping to match API proposal

changeset-bot · 2023-07-13T18:26:25Z

⚠️ No Changeset found

Latest commit: e505279

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2023-07-13T18:47:01Z

Size Report ¹

Affected Products

`@firebase/auth`

Type	Base (`97f46f5`)	Merge (`119e743`)	Diff
browser	173 kB	175 kB	+1.91 kB (+1.1%)
cordova	202 kB	204 kB	+2.00 kB (+1.0%)
esm5	227 kB	229 kB	+2.00 kB (+0.9%)
main	171 kB	173 kB	+2.00 kB (+1.2%)
module	173 kB	175 kB	+1.91 kB (+1.1%)
react-native	186 kB	188 kB	+2.00 kB (+1.1%)

@firebase/auth/cordova
Type Base (97f46f5) Merge (119e743) Diff
browser 202 kB 204 kB +2.00 kB (+1.0%)
module 202 kB 204 kB +2.00 kB (+1.0%)
@firebase/auth/internal
Type Base (97f46f5) Merge (119e743) Diff
browser 184 kB 186 kB +1.91 kB (+1.0%)
esm5 240 kB 242 kB +2.00 kB (+0.8%)
main 207 kB 209 kB +2.00 kB (+1.0%)
module 184 kB 186 kB +1.91 kB (+1.0%)
@firebase/auth/react-native
Type Base (97f46f5) Merge (119e743) Diff
browser 186 kB 188 kB +2.00 kB (+1.1%)
module 186 kB 188 kB +2.00 kB (+1.1%)

`bundle`

Type	Base (`97f46f5`)	Merge (`119e743`)	Diff
auth (Anonymous)	73.0 kB	74.5 kB	+1.46 kB (+2.0%)
auth (EmailAndPassword)	78.0 kB	79.4 kB	+1.46 kB (+1.9%)
auth (GoogleFBTwitterGitHubPopup)	99.2 kB	101 kB	+1.46 kB (+1.5%)
auth (GooglePopup)	96.5 kB	98.0 kB	+1.46 kB (+1.5%)
auth (GoogleRedirect)	96.7 kB	98.2 kB	+1.46 kB (+1.5%)
auth (Phone)	82.9 kB	84.3 kB	+1.46 kB (+1.8%)

`firebase`

Type	Base (`97f46f5`)	Merge (`119e743`)	Diff
firebase-auth-compat.js	134 kB	136 kB	+1.41 kB (+1.0%)
firebase-auth-cordova.js	150 kB	152 kB	+1.46 kB (+1.0%)
firebase-auth-react-native.js	163 kB	164 kB	+1.46 kB (+0.9%)
firebase-auth.js	129 kB	130 kB	+1.41 kB (+1.1%)
firebase-compat.js	775 kB	777 kB	+1.41 kB (+0.2%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/wNQ5m6MPk3.html

google-oss-bot · 2023-07-13T19:03:36Z

Size Analysis Report ¹

Affected Products

@firebase/auth
- ActionCodeOperation
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.2 kB 38.7 kB +1.46 kB (+3.9%)
  size-with-ext-deps 58.0 kB 59.4 kB +1.46 kB (+2.5%)
- ActionCodeURL
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 38.0 kB 39.5 kB +1.46 kB (+3.8%)
  size-with-ext-deps 59.1 kB 60.5 kB +1.46 kB (+2.5%)
- AuthCredential
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.2 kB 38.7 kB +1.46 kB (+3.9%)
  size-with-ext-deps 58.0 kB 59.4 kB +1.46 kB (+2.5%)
- AuthErrorCodes
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 42.0 kB 43.5 kB +1.46 kB (+3.5%)
  size-with-ext-deps 62.8 kB 64.3 kB +1.46 kB (+2.3%)
- EmailAuthCredential
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 39.8 kB 41.3 kB +1.46 kB (+3.7%)
  size-with-ext-deps 60.6 kB 62.1 kB +1.46 kB (+2.4%)
- EmailAuthProvider
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 41.3 kB 42.7 kB +1.46 kB (+3.5%)
  size-with-ext-deps 62.3 kB 63.8 kB +1.46 kB (+2.3%)
- FacebookAuthProvider
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 42.0 kB 43.5 kB +1.46 kB (+3.5%)
  size-with-ext-deps 62.8 kB 64.3 kB +1.46 kB (+2.3%)
- FactorId
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.0 kB 38.4 kB +1.46 kB (+3.9%)
  size-with-ext-deps 57.8 kB 59.2 kB +1.46 kB (+2.5%)
- GithubAuthProvider
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 42.0 kB 43.5 kB +1.46 kB (+3.5%)
  size-with-ext-deps 62.8 kB 64.3 kB +1.46 kB (+2.3%)
- GoogleAuthProvider
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 42.0 kB 43.5 kB +1.46 kB (+3.5%)
  size-with-ext-deps 62.8 kB 64.3 kB +1.46 kB (+2.3%)
- OAuthCredential
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 39.1 kB 40.6 kB +1.46 kB (+3.7%)
  size-with-ext-deps 59.9 kB 61.3 kB +1.46 kB (+2.4%)
- OAuthProvider
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 42.9 kB 44.4 kB +1.46 kB (+3.4%)
  size-with-ext-deps 63.7 kB 65.2 kB +1.46 kB (+2.3%)
- OperationType
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.0 kB 38.5 kB +1.46 kB (+3.9%)
  size-with-ext-deps 57.8 kB 59.3 kB +1.46 kB (+2.5%)
- PhoneAuthCredential
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 39.1 kB 40.6 kB +1.46 kB (+3.7%)
  size-with-ext-deps 59.9 kB 61.3 kB +1.46 kB (+2.4%)
- PhoneAuthProvider
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 40.8 kB 42.2 kB +1.46 kB (+3.6%)
  size-with-ext-deps 61.6 kB 63.0 kB +1.46 kB (+2.4%)
- PhoneMultiFactorGenerator
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.8 kB 39.3 kB +1.46 kB (+3.9%)
  size-with-ext-deps 58.6 kB 60.1 kB +1.46 kB (+2.5%)
- ProviderId
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.1 kB 38.5 kB +1.46 kB (+3.9%)
  size-with-ext-deps 57.9 kB 59.3 kB +1.46 kB (+2.5%)
- RecaptchaVerifier
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 43.2 kB 44.6 kB +1.46 kB (+3.4%)
  size-with-ext-deps 64.0 kB 65.4 kB +1.46 kB (+2.3%)
- SAMLAuthProvider
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 43.3 kB 44.7 kB +1.46 kB (+3.4%)
  size-with-ext-deps 64.1 kB 65.5 kB +1.46 kB (+2.3%)
- SignInMethod
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.1 kB 38.6 kB +1.46 kB (+3.9%)
  size-with-ext-deps 57.9 kB 59.3 kB +1.46 kB (+2.5%)
- TotpMultiFactorGenerator
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 39.5 kB 40.9 kB +1.46 kB (+3.7%)
  size-with-ext-deps 60.3 kB 61.7 kB +1.46 kB (+2.4%)
- TotpSecret
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.9 kB 39.4 kB +1.46 kB (+3.8%)
  size-with-ext-deps 58.7 kB 60.2 kB +1.46 kB (+2.5%)
- TwitterAuthProvider
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 42.0 kB 43.5 kB +1.46 kB (+3.5%)
  size-with-ext-deps 62.8 kB 64.3 kB +1.46 kB (+2.3%)
- applyActionCode
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.1 kB 38.5 kB +1.46 kB (+3.9%)
  size-with-ext-deps 57.8 kB 59.3 kB +1.46 kB (+2.5%)
- beforeAuthStateChanged
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.0 kB 38.5 kB +1.46 kB (+3.9%)
  size-with-ext-deps 57.8 kB 59.3 kB +1.46 kB (+2.5%)
- browserLocalPersistence
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 40.4 kB 41.8 kB +1.46 kB (+3.6%)
  size-with-ext-deps 61.2 kB 62.7 kB +1.46 kB (+2.4%)
- browserPopupRedirectResolver
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 61.0 kB 62.5 kB +1.46 kB (+2.4%)
  size-with-ext-deps 82.0 kB 83.5 kB +1.46 kB (+1.8%)
- browserSessionPersistence
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 40.4 kB 41.8 kB +1.46 kB (+3.6%)
  size-with-ext-deps 61.2 kB 62.7 kB +1.46 kB (+2.4%)
- checkActionCode
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 38.2 kB 39.6 kB +1.46 kB (+3.8%)
  size-with-ext-deps 59.0 kB 60.4 kB +1.46 kB (+2.5%)
- confirmPasswordReset
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.1 kB 38.6 kB +1.46 kB (+3.9%)
  size-with-ext-deps 57.9 kB 59.3 kB +1.46 kB (+2.5%)
- connectAuthEmulator
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 38.7 kB 40.1 kB +1.46 kB (+3.8%)
  size-with-ext-deps 59.5 kB 60.9 kB +1.46 kB (+2.5%)
- createUserWithEmailAndPassword
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 39.0 kB 40.4 kB +1.46 kB (+3.7%)
  size-with-ext-deps 59.7 kB 61.2 kB +1.46 kB (+2.4%)
- debugErrorMap
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 49.2 kB 50.6 kB +1.46 kB (+3.0%)
  size-with-ext-deps 69.9 kB 71.4 kB +1.46 kB (+2.1%)
- deleteUser
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.0 kB 38.4 kB +1.46 kB (+3.9%)
  size-with-ext-deps 57.8 kB 59.2 kB +1.46 kB (+2.5%)
- fetchSignInMethodsForEmail
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.3 kB 38.8 kB +1.46 kB (+3.9%)
  size-with-ext-deps 58.1 kB 59.5 kB +1.46 kB (+2.5%)
- getAdditionalUserInfo
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 38.3 kB 39.7 kB +1.46 kB (+3.8%)
  size-with-ext-deps 59.1 kB 60.5 kB +1.46 kB (+2.5%)
- getAuth
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 71.1 kB 72.5 kB +1.46 kB (+2.1%)
  size-with-ext-deps 98.6 kB 100 kB +1.46 kB (+1.5%)
- getIdToken
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.0 kB 38.5 kB +1.46 kB (+3.9%)
  size-with-ext-deps 57.8 kB 59.2 kB +1.46 kB (+2.5%)
- getIdTokenResult
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 36.9 kB 38.4 kB +1.46 kB (+3.9%)
  size-with-ext-deps 57.7 kB 59.2 kB +1.46 kB (+2.5%)
- getMultiFactorResolver
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 39.9 kB 41.3 kB +1.46 kB (+3.7%)
  size-with-ext-deps 60.6 kB 62.1 kB +1.46 kB (+2.4%)
- getRedirectResult
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 44.5 kB 46.0 kB +1.46 kB (+3.3%)
  size-with-ext-deps 65.3 kB 66.8 kB +1.46 kB (+2.2%)
- inMemoryPersistence
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.0 kB 38.4 kB +1.46 kB (+3.9%)
  size-with-ext-deps 57.7 kB 59.2 kB +1.46 kB (+2.5%)
- indexedDBLocalPersistence
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 44.4 kB 45.8 kB +1.46 kB (+3.3%)
  size-with-ext-deps 65.2 kB 66.6 kB +1.46 kB (+2.2%)
- initializeAuth
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.2 kB 38.7 kB +1.46 kB (+3.9%)
  size-with-ext-deps 58.5 kB 59.9 kB +1.46 kB (+2.5%)
- initializeRecaptchaConfig
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.0 kB 38.5 kB +1.46 kB (+3.9%)
  size-with-ext-deps 57.8 kB 59.3 kB +1.46 kB (+2.5%)
- isSignInWithEmailLink
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 38.2 kB 39.6 kB +1.46 kB (+3.8%)
  size-with-ext-deps 59.2 kB 60.6 kB +1.46 kB (+2.5%)
- linkWithCredential
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 38.0 kB 39.4 kB +1.46 kB (+3.8%)
  size-with-ext-deps 58.8 kB 60.2 kB +1.46 kB (+2.5%)
- linkWithPhoneNumber
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 41.5 kB 43.0 kB +1.46 kB (+3.5%)
  size-with-ext-deps 62.3 kB 63.8 kB +1.46 kB (+2.3%)
- linkWithPopup
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 48.1 kB 49.5 kB +1.46 kB (+3.0%)
  size-with-ext-deps 68.9 kB 70.3 kB +1.46 kB (+2.1%)
- linkWithRedirect
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 43.3 kB 44.8 kB +1.46 kB (+3.4%)
  size-with-ext-deps 64.1 kB 65.6 kB +1.46 kB (+2.3%)
- multiFactor
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 39.2 kB 40.6 kB +1.46 kB (+3.7%)
  size-with-ext-deps 60.0 kB 61.4 kB +1.46 kB (+2.4%)
- onAuthStateChanged
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.0 kB 38.5 kB +1.46 kB (+3.9%)
  size-with-ext-deps 57.8 kB 59.2 kB +1.46 kB (+2.5%)
- onIdTokenChanged
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.0 kB 38.5 kB +1.46 kB (+3.9%)
  size-with-ext-deps 57.8 kB 59.2 kB +1.46 kB (+2.5%)
- parseActionCodeURL
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 38.1 kB 39.5 kB +1.46 kB (+3.8%)
  size-with-ext-deps 59.1 kB 60.6 kB +1.46 kB (+2.5%)
- prodErrorMap
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 36.9 kB 38.4 kB +1.46 kB (+3.9%)
  size-with-ext-deps 57.7 kB 59.2 kB +1.46 kB (+2.5%)
- reauthenticateWithCredential
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 38.6 kB 40.0 kB +1.46 kB (+3.8%)
  size-with-ext-deps 59.3 kB 60.8 kB +1.46 kB (+2.5%)
- reauthenticateWithPhoneNumber
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 42.1 kB 43.5 kB +1.46 kB (+3.5%)
  size-with-ext-deps 62.9 kB 64.3 kB +1.46 kB (+2.3%)
- reauthenticateWithPopup
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 48.1 kB 49.5 kB +1.46 kB (+3.0%)
  size-with-ext-deps 68.9 kB 70.3 kB +1.46 kB (+2.1%)
- reauthenticateWithRedirect
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 43.1 kB 44.5 kB +1.46 kB (+3.4%)
  size-with-ext-deps 63.8 kB 65.3 kB +1.46 kB (+2.3%)
- reload
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 36.9 kB 38.4 kB +1.46 kB (+3.9%)
  size-with-ext-deps 57.7 kB 59.2 kB +1.46 kB (+2.5%)
- sendEmailVerification
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.9 kB 39.3 kB +1.46 kB (+3.9%)
  size-with-ext-deps 58.7 kB 60.1 kB +1.46 kB (+2.5%)
- sendPasswordResetEmail
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 38.7 kB 40.1 kB +1.46 kB (+3.8%)
  size-with-ext-deps 59.4 kB 60.9 kB +1.46 kB (+2.5%)
- sendSignInLinkToEmail
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 38.7 kB 40.2 kB +1.46 kB (+3.8%)
  size-with-ext-deps 59.5 kB 60.9 kB +1.46 kB (+2.5%)
- setPersistence
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.0 kB 38.5 kB +1.46 kB (+3.9%)
  size-with-ext-deps 57.8 kB 59.2 kB +1.46 kB (+2.5%)
- signInAnonymously
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 38.1 kB 39.6 kB +1.46 kB (+3.8%)
  size-with-ext-deps 58.9 kB 60.4 kB +1.46 kB (+2.5%)
- signInWithCredential
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 38.3 kB 39.8 kB +1.46 kB (+3.8%)
  size-with-ext-deps 59.1 kB 60.6 kB +1.46 kB (+2.5%)
- signInWithCustomToken
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 38.0 kB 39.4 kB +1.46 kB (+3.8%)
  size-with-ext-deps 58.8 kB 60.2 kB +1.46 kB (+2.5%)
- signInWithEmailAndPassword
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 42.7 kB 44.2 kB +1.46 kB (+3.4%)
  size-with-ext-deps 63.8 kB 65.2 kB +1.46 kB (+2.3%)
- signInWithEmailLink
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 42.9 kB 44.4 kB +1.46 kB (+3.4%)
  size-with-ext-deps 64.0 kB 65.4 kB +1.46 kB (+2.3%)
- signInWithPhoneNumber
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 41.9 kB 43.3 kB +1.46 kB (+3.5%)
  size-with-ext-deps 62.7 kB 64.1 kB +1.46 kB (+2.3%)
- signInWithPopup
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 48.1 kB 49.5 kB +1.46 kB (+3.0%)
  size-with-ext-deps 68.9 kB 70.3 kB +1.46 kB (+2.1%)
- signInWithRedirect
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 42.8 kB 44.2 kB +1.46 kB (+3.4%)
  size-with-ext-deps 63.5 kB 65.0 kB +1.46 kB (+2.3%)
- signOut
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.0 kB 38.4 kB +1.46 kB (+3.9%)
  size-with-ext-deps 57.8 kB 59.2 kB +1.46 kB (+2.5%)
- unlink
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.5 kB 39.0 kB +1.46 kB (+3.9%)
  size-with-ext-deps 58.3 kB 59.8 kB +1.46 kB (+2.5%)
- updateCurrentUser
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.0 kB 38.5 kB +1.46 kB (+3.9%)
  size-with-ext-deps 57.8 kB 59.2 kB +1.46 kB (+2.5%)
- updateEmail
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.3 kB 38.7 kB +1.46 kB (+3.9%)
  size-with-ext-deps 58.0 kB 59.5 kB +1.46 kB (+2.5%)
- updatePassword
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.3 kB 38.7 kB +1.46 kB (+3.9%)
  size-with-ext-deps 58.0 kB 59.5 kB +1.46 kB (+2.5%)
- updatePhoneNumber
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.7 kB 39.2 kB +1.46 kB (+3.9%)
  size-with-ext-deps 58.5 kB 60.0 kB +1.46 kB (+2.5%)
- updateProfile
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.5 kB 38.9 kB +1.46 kB (+3.9%)
  size-with-ext-deps 58.2 kB 59.7 kB +1.46 kB (+2.5%)
- useDeviceLanguage
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.0 kB 38.4 kB +1.46 kB (+3.9%)
  size-with-ext-deps 57.8 kB 59.2 kB +1.46 kB (+2.5%)
- validatePassword
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.0 kB 38.5 kB +1.46 kB (+3.9%)
  size-with-ext-deps 57.8 kB 59.3 kB +1.46 kB (+2.5%)
- verifyBeforeUpdateEmail
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 37.9 kB 39.4 kB +1.46 kB (+3.8%)
  size-with-ext-deps 58.7 kB 60.2 kB +1.46 kB (+2.5%)
- verifyPasswordResetCode
  Size
  Type Base (97f46f5) Merge (119e743) Diff
  size 38.3 kB 39.7 kB +1.46 kB (+3.8%)
  size-with-ext-deps 59.0 kB 60.5 kB +1.46 kB (+2.5%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/tqLO9JET7i.html

Xiaoshouzi-gh

LGTM

…tch API proposal (#7456) * Implement validatePassword * Fix allowedNonAlphanumericCharacters typing to match API proposal

Implement validatePassword and fix allowedNonAlphanumericCharacters t…

ee2acc0

…yping to match API proposal

ch5zzy added 2 commits July 13, 2023 11:33

Add comment about policy being defined after fetching

6b9d734

Update test case name

7ad0cef

Update docs and formatting

daf078a

Update API reports

e505279

ch5zzy requested a review from Xiaoshouzi-gh July 13, 2023 20:58

ch5zzy marked this pull request as ready for review July 13, 2023 20:58

ch5zzy requested review from egilmorez, markarndt, kevinthecheung, lisajian, prameshj, renkelvin, sam-gc, a team, dwyfrequency and hsubox76 as code owners July 13, 2023 20:58

Xiaoshouzi-gh approved these changes Jul 13, 2023

View reviewed changes

ch5zzy merged commit d40ca7d into password-policy Jul 13, 2023

ch5zzy deleted the implement-validate-password branch July 13, 2023 21:31

ch5zzy added a commit that referenced this pull request Jul 13, 2023

Implement validatePassword endpoint and fix PasswordPolicy type to ma…

b87eb45

…tch API proposal (#7456) * Implement validatePassword * Fix allowedNonAlphanumericCharacters typing to match API proposal

firebase locked and limited conversation to collaborators Aug 13, 2023

Implement validatePassword endpoint and fix PasswordPolicy type to match API proposal #7456

Implement validatePassword endpoint and fix PasswordPolicy type to match API proposal #7456

Uh oh!

Conversation

ch5zzy commented Jul 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jul 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

google-oss-bot commented Jul 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/auth

@firebase/auth/cordova

@firebase/auth/internal

@firebase/auth/react-native

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented Jul 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Affected Products

@firebase/auth

ActionCodeOperation

ActionCodeURL

AuthCredential

AuthErrorCodes

EmailAuthCredential

EmailAuthProvider

FacebookAuthProvider

FactorId

GithubAuthProvider

GoogleAuthProvider

OAuthCredential

OAuthProvider

OperationType

PhoneAuthCredential

PhoneAuthProvider

PhoneMultiFactorGenerator

ProviderId

RecaptchaVerifier

SAMLAuthProvider

SignInMethod

TotpMultiFactorGenerator

TotpSecret

TwitterAuthProvider

applyActionCode

beforeAuthStateChanged

browserLocalPersistence

browserPopupRedirectResolver

browserSessionPersistence

checkActionCode

confirmPasswordReset

connectAuthEmulator

createUserWithEmailAndPassword

debugErrorMap

deleteUser

fetchSignInMethodsForEmail

getAdditionalUserInfo

getAuth

getIdToken

getIdTokenResult

getMultiFactorResolver

getRedirectResult

inMemoryPersistence

indexedDBLocalPersistence

initializeAuth

initializeRecaptchaConfig

isSignInWithEmailLink

linkWithCredential

linkWithPhoneNumber

linkWithPopup

linkWithRedirect

multiFactor

onAuthStateChanged

ch5zzy commented Jul 13, 2023 •

edited

Loading

changeset-bot bot commented Jul 13, 2023 •

edited

Loading

google-oss-bot commented Jul 13, 2023 •

edited

Loading

Size Report ¹

`@firebase/auth`

`@firebase/auth/cordova`

`@firebase/auth/internal`

`@firebase/auth/react-native`

`bundle`

`firebase`

google-oss-bot commented Jul 13, 2023 •

edited

Loading

Size Analysis Report ¹

`@firebase/auth`

`ActionCodeOperation`

`ActionCodeURL`

`AuthCredential`

`AuthErrorCodes`

`EmailAuthCredential`

`EmailAuthProvider`

`FacebookAuthProvider`

`FactorId`

`GithubAuthProvider`

`GoogleAuthProvider`

`OAuthCredential`

`OAuthProvider`

`OperationType`

`PhoneAuthCredential`

`PhoneAuthProvider`

`PhoneMultiFactorGenerator`

`ProviderId`

`RecaptchaVerifier`

`SAMLAuthProvider`

`SignInMethod`

`TotpMultiFactorGenerator`

`TotpSecret`

`TwitterAuthProvider`

`applyActionCode`

`beforeAuthStateChanged`

`browserLocalPersistence`

`browserPopupRedirectResolver`

`browserSessionPersistence`

`checkActionCode`

`confirmPasswordReset`

`connectAuthEmulator`

`createUserWithEmailAndPassword`

`debugErrorMap`

`deleteUser`

`fetchSignInMethodsForEmail`

`getAdditionalUserInfo`

`getAuth`

`getIdToken`

`getIdTokenResult`

`getMultiFactorResolver`

`getRedirectResult`

`inMemoryPersistence`

`indexedDBLocalPersistence`

`initializeAuth`

`initializeRecaptchaConfig`

`isSignInWithEmailLink`

`linkWithCredential`

`linkWithPhoneNumber`

`linkWithPopup`

`linkWithRedirect`

`multiFactor`

`onAuthStateChanged`

`onIdTokenChanged`

`parseActionCodeURL`

`prodErrorMap`

`reauthenticateWithCredential`

`reauthenticateWithPhoneNumber`

`reauthenticateWithPopup`

`reauthenticateWithRedirect`

`reload`

`sendEmailVerification`

`sendPasswordResetEmail`

`sendSignInLinkToEmail`

`setPersistence`

`signInAnonymously`

`signInWithCredential`

`signInWithCustomToken`